Source: nbdkit
Version: 1.40.4-1
Tags: patch

  nbdkit used to include the VDDK plugin, until it was removed in
version 1.16.1-2. I would like to request that it be packaged once
again, since the plugin itself is licensed as BSD-3-clause. I recently
encountered a case where I would have liked to use the VDDK plugin, but
wasn't able to natively use the Debian packaging and had to rebuild it
myself. There's also a bug downstream in Ubuntu asking for the VDDK
plugin to be packaged[1].

  I've attached a patch with the packaging changes needed to
reintroduce a bin:nbdkit-plugin-vddk package.

  As bin:nbdkit-plugin-vddk depends on a proprietary VMware library to
be useful, it should be placed into the "contrib" section of the
archive as described in Policy Section 2.2.

Thanks,
Mathias

[1] -- https://bugs.launchpad.net/ubuntu/+source/nbdkit/+bug/2056064
diff --git a/debian/changelog b/debian/changelog
index 3594060..4ed7e6c 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,9 @@
+nbdkit (1.40.4-2) UNRELEASED; urgency=medium
+
+  * Reintroduce a bin:nbdkit-plugin-vddk package
+
+ -- Mathias Gibbens <gib...@debian.org>  Wed, 09 Oct 2024 21:51:09 +0000
+
 nbdkit (1.40.4-1) unstable; urgency=medium
 
   * New upstream version 1.40.4
diff --git a/debian/control b/debian/control
index a060eb0..421b5c1 100644
--- a/debian/control
+++ b/debian/control
@@ -139,3 +139,20 @@ Conflicts: nbdkit (<< 1.1.5-2~)
 Description: libguestfs plugin for nbdkit
  nbdkit-guestfs-plugin is an nbdkit(1) plugin that makes the contents
  of disk images accessible over NBD.
+
+Package: nbdkit-plugin-vddk
+Section: contrib/admin
+Architecture: linux-any
+Multi-Arch: same
+Depends: ${shlibs:Depends}, ${misc:Depends}, nbdkit,
+Conflicts: nbdkit (<< 1.1.5-2~)
+Description: vddk plugin for nbdkit
+ nbdkit-vddk-plugin is an nbdkit(1) plugin that makes the contents of
+ VMDK files and VMware disks accessible over NBD.
+ .
+ VDDK (Virtual Disk Development Kit) is a proprietary VMware library
+ for accessing VMDK files and VMware ESX servers. Note that the
+ license of the VDDK library is highly restrictive, preventing any
+ commercial usage without negotiating a separate license from VMware.
+ This plugin does not contain any VMware code. Consult the man page
+ nbdkit-vddk-plugin(1) for details on how to use this plugin.
diff --git a/debian/nbdkit-plugin-vddk.install b/debian/nbdkit-plugin-vddk.install
new file mode 100644
index 0000000..e4b772c
--- /dev/null
+++ b/debian/nbdkit-plugin-vddk.install
@@ -0,0 +1,2 @@
+/usr/lib/*-*/nbdkit/plugins/nbdkit-vddk-plugin.so
+/usr/share/man/man1/nbdkit-vddk-plugin.1
diff --git a/debian/rules b/debian/rules
index a8053b7..5ecd018 100755
--- a/debian/rules
+++ b/debian/rules
@@ -15,7 +15,7 @@
        dh $@ --with autoreconf
 
 override_dh_auto_configure:
-	dh_auto_configure -- --disable-vddk --sbindir=/usr/bin MKE2FS=/sbin/mke2fs $(EXTRA_CONFIG_ARGS)
+	dh_auto_configure -- --sbindir=/usr/bin MKE2FS=/sbin/mke2fs $(EXTRA_CONFIG_ARGS)
 
 override_dh_auto_test: PATH := $(PATH):/sbin
 override_dh_auto_test:

Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to