Package: broadcom-sta-dkms
Version: 6.30.223.271-24
Severity: minor
X-Debbugs-Cc: die...@gnome.org

On 6.11, it seems there are a few API updates we need to take care of:

Something called a "return thunk":

```
  kernel: wl: loading out-of-tree module taints kernel.
  kernel: wl: module license 'MIXED/Proprietary' taints kernel.
  kernel: Disabling lock debugging due to kernel taint
  kernel: wl: module license taints kernel.
  kernel: ------------[ cut here ]------------
  kernel: Unpatched return thunk in use. This should not happen!
  kernel: WARNING: CPU: 0 PID: 577 at arch/x86/kernel/cpu/bugs.c:3029 
__warn_thunk+0x2a/0x40
  kernel: Modules linked in: wl(POE+) nls_ascii nls_cp437 vfat fat 
x86_pkg_temp_thermal intel_powerclamp kvm_intel snd_hda_codec_cirrus 
snd_hda_codec_generic kvm snd_hda_codec_hdmi snd_hda_intel snd_intel_dspcfg 
snd_intel_sdw_acpi snd_hda_codec cfg80211 applesmc mei_hdcp mei_pxp 
snd_hda_core rapl iTCO_wdt snd_hwdep intel_cstate intel_pmc_bxt intel_uncore 
iTCO_vendor_support watchdog snd_pcm rfkill pcspkr mei_me snd_timer acpi_als 
mei snd soundcore industrialio_triggered_buffer kfifo_buf sbs industrialio 
sbshc ac evdev sg coretemp msr efi_pstore configfs nfnetlink efivarfs ip_tables 
x_tables autofs4 ext4 crc16 mbcache jbd2 crc32c_generic dm_crypt dm_mod 
hid_apple hid_generic usbhid hid uas usb_storage sd_mod i915 drm_buddy 
i2c_algo_bit ahci crct10dif_pclmul drm_display_helper crc32_pclmul crc32c_intel 
libahci xhci_pci xhci_hcd cec libata rc_core ghash_clmulni_intel usbcore ttm 
sha512_ssse3 scsi_mod drm_kms_helper i2c_i801 video sha256_ssse3 drm sha1_ssse3 
i2c_smbus usb_common lpc_ich scsi_common wmi battery button
  kernel:  aesni_intel gf128mul crypto_simd cryptd
  kernel: CPU: 0 UID: 0 PID: 577 Comm: (udev-worker) Tainted: P     U     OE    
  6.11.2-amd64 #1  Debian 6.11.2-1
  kernel: Tainted: [P]=PROPRIETARY_MODULE, [U]=USER, [O]=OOT_MODULE, 
[E]=UNSIGNED_MODULE
  kernel: Hardware name: Apple Inc. MacBookPro11,1/Mac-189A3D4F975D5FFC, BIOS 
478.0.0.0.0 01/13/2023
  kernel: RIP: 0010:__warn_thunk+0x2a/0x40
  kernel: Code: 66 0f 1f 00 0f 1f 44 00 00 80 3d d8 c9 db 01 00 74 05 c3 cc cc 
cc cc 48 c7 c7 68 3d af a3 c6 05 c3 c9 db 01 01 e8 96 1f 06 00 <0f> 0b c3 cc cc 
cc cc 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00
  kernel: RSP: 0018:ffffb1cac069bb00 EFLAGS: 00010282
  kernel: RAX: 0000000000000000 RBX: 0000000000000000 RCX: 0000000000000027
  kernel: RDX: ffff943f27221788 RSI: 0000000000000001 RDI: ffff943f27221780
  kernel: RBP: ffffb1cac069bb50 R08: 0000000000000000 R09: ffffb1cac069b980
  kernel: R10: ffffffffa42b41e8 R11: 0000000000000003 R12: ffffffffc1b10c21
  kernel: R13: ffffb1cac069bb98 R14: ffff943dcfd36600 R15: ffff943df0cc61a0
  kernel: FS:  00007fe375efb900(0000) GS:ffff943f27200000(0000) 
knlGS:0000000000000000
  kernel: CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
  kernel: CR2: 0000559632104d79 CR3: 00000001e4ff4002 CR4: 00000000001706f0
  kernel: Call Trace:
  kernel:  <TASK>
  kernel:  ? __warn_thunk+0x2a/0x40
  kernel:  ? __warn.cold+0x8e/0xe8
  kernel:  ? __warn_thunk+0x2a/0x40
  kernel:  ? report_bug+0xff/0x140
  kernel:  ? handle_bug+0x3c/0x80
  kernel:  ? exc_invalid_op+0x17/0x70
  kernel:  ? asm_exc_invalid_op+0x1a/0x20
  kernel:  ? __warn_thunk+0x2a/0x40
  kernel:  warn_thunk_thunk+0x1a/0x30
  kernel:  getvar+0x20/0x70 [wl]
  kernel:  ? ____versions+0x4e34ffe701f0/0x4e34ffe701f0 [wl]
  kernel:  wl_module_init+0x17/0xa0 [wl]
  kernel:  ? do_one_initcall+0x5b/0x310
  kernel:  ? do_init_module+0x60/0x230
  kernel:  ? init_module_from_file+0x89/0xe0
  kernel:  ? idempotent_init_module+0x121/0x320
  kernel:  ? __x64_sys_finit_module+0x5e/0xb0
  kernel:  ? do_syscall_64+0x82/0x190
  kernel:  ? restore_fpregs_from_fpstate+0x3c/0xa0
  kernel:  ? switch_fpu_return+0x4e/0xd0
  kernel:  ? __seccomp_filter+0x303/0x520
  kernel:  ? syscall_exit_to_user_mode+0x4d/0x210
  kernel:  ? do_syscall_64+0x8e/0x190
  kernel:  ? entry_SYSCALL_64_after_hwframe+0x76/0x7e
  kernel:  </TASK>
  kernel: ---[ end trace 0000000000000000 ]---
```

A `memcpy`:

```
  kernel: wlan0: Broadcom BCM43a0 802.11 Hybrid Wireless Controller 
6.30.223.271 (r587334)
  kernel: ------------[ cut here ]------------
  kernel: memcpy: detected field-spanning write (size 160) of single field 
"dst" at 
/var/lib/dkms/broadcom-sta/6.30.223.271/build/src/wl/sys/wl_cfg80211_hybrid.c:3086
 (size 0)
  kernel: WARNING: CPU: 2 PID: 852 at 
/var/lib/dkms/broadcom-sta/6.30.223.271/build/src/wl/sys/wl_cfg80211_hybrid.c:3086
 wl_inform_single_bss+0x392/0x4f0 [wl]
  kernel: Modules linked in: snd_seq_dummy snd_hrtimer snd_seq snd_seq_device 
btusb btrtl btintel btbcm btmtk bluetooth qrtr joydev bcm5974 
apple_mfi_fastcharge binfmt_misc intel_rapl_msr intel_rapl_common wl(POE) 
nls_ascii nls_cp437 vfat fat x86_pkg_temp_thermal intel_powerclamp kvm_intel 
snd_hda_codec_cirrus snd_hda_codec_generic kvm snd_hda_codec_hdmi snd_hda_intel 
snd_intel_dspcfg snd_intel_sdw_acpi snd_hda_codec cfg80211 applesmc mei_hdcp 
mei_pxp snd_hda_core rapl iTCO_wdt snd_hwdep intel_cstate intel_pmc_bxt 
intel_uncore iTCO_vendor_support watchdog snd_pcm rfkill pcspkr mei_me 
snd_timer acpi_als mei snd soundcore industrialio_triggered_buffer kfifo_buf 
sbs industrialio sbshc ac evdev sg coretemp msr efi_pstore configfs nfnetlink 
efivarfs ip_tables x_tables autofs4 ext4 crc16 mbcache jbd2 crc32c_generic 
dm_crypt dm_mod hid_apple hid_generic usbhid hid uas usb_storage sd_mod i915 
drm_buddy i2c_algo_bit ahci crct10dif_pclmul drm_display_helper crc32_pclmul 
crc32c_intel libahci xhci_pci xhci_hcd cec libata
  kernel:  rc_core ghash_clmulni_intel usbcore ttm sha512_ssse3 scsi_mod 
drm_kms_helper i2c_i801 video sha256_ssse3 drm sha1_ssse3 i2c_smbus usb_common 
lpc_ich scsi_common wmi battery button aesni_intel gf128mul crypto_simd cryptd
  kernel: CPU: 2 UID: 0 PID: 852 Comm: wl_event_handle Tainted: P     U  W  OE  
    6.11.2-amd64 #1  Debian 6.11.2-1
  kernel: Tainted: [P]=PROPRIETARY_MODULE, [U]=USER, [W]=WARN, [O]=OOT_MODULE, 
[E]=UNSIGNED_MODULE
  kernel: Hardware name: Apple Inc. MacBookPro11,1/Mac-189A3D4F975D5FFC, BIOS 
478.0.0.0.0 01/13/2023
  kernel: RIP: 0010:wl_inform_single_bss+0x392/0x4f0 [wl]
  kernel: Code: 0f 85 dd fd ff ff 31 c9 4c 89 e6 48 c7 c2 d8 22 b1 c1 48 c7 c7 
30 22 b1 c1 48 89 44 24 10 c6 05 f8 a6 15 00 01 e8 ae ed 04 e1 <0f> 0b 48 8b 44 
24 10 e9 ad fd ff ff 8b 0e 41 89 8f 1a 04 00 00 42
  kernel: RSP: 0018:ffffb1cac06d3dc8 EFLAGS: 00010282
  kernel: RAX: 0000000000000000 RBX: ffff943dc127c00c RCX: 0000000000000027
  kernel: RDX: ffff943f27321788 RSI: 0000000000000001 RDI: ffff943f27321780
  kernel: RBP: ffff943de1b4d000 R08: 0000000000000000 R09: ffffb1cac06d3c48
  kernel: R10: ffffffffa42b41e8 R11: 0000000000000003 R12: 00000000000000a0
  kernel: R13: ffff943dc127c014 R14: 0000000000000050 R15: ffff943dd19dc900
  kernel: FS:  0000000000000000(0000) GS:ffff943f27300000(0000) 
knlGS:0000000000000000
  kernel: CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
  kernel: CR2: 00007f8054002000 CR3: 00000001e4622005 CR4: 00000000001706f0
  kernel: Call Trace:
  kernel:  <TASK>
  kernel:  ? wl_inform_single_bss+0x392/0x4f0 [wl]
  kernel:  ? __warn.cold+0x8e/0xe8
  kernel:  ? wl_inform_single_bss+0x392/0x4f0 [wl]
  kernel:  ? report_bug+0xff/0x140
  kernel:  ? console_unlock+0x84/0x130
  kernel:  ? handle_bug+0x3c/0x80
  kernel:  ? exc_invalid_op+0x17/0x70
  kernel:  ? asm_exc_invalid_op+0x1a/0x20
  kernel:  ? wl_inform_single_bss+0x392/0x4f0 [wl]
  kernel:  ? wl_inform_single_bss+0x392/0x4f0 [wl]
  kernel:  ? warn_thunk_thunk+0x1a/0x30
  kernel:  ? wl_notify_scan_status+0x1bd/0x260 [wl]
  kernel:  ? wl_event_handler+0x7a/0x170 [wl]
  kernel:  ? wl_cfg80211_add_key+0x3f0/0x3f0 [wl]
  kernel:  ? kthread+0xd2/0x100
  kernel:  ? __pfx_kthread+0x10/0x10
  kernel:  ? ret_from_fork+0x34/0x50
  kernel:  ? __pfx_kthread+0x10/0x10
  kernel:  ? ret_from_fork_asm+0x1a/0x30
  kernel:  </TASK>
  kernel: ---[ end trace 0000000000000000 ]---
  kernel: warning: `Socket Thread' uses wireless extensions which will stop 
working for Wi-Fi 7 hardware; use nl80211
```

And not sure if that "Socket Thread" warning is a consequence of any of
the above warnings.

I have not tried this out long enough to see if it has real
consequences, but as usual it would be great to fix these. But fwiw, it
seems these are harmless _for now_.

I do not plan to try patching these anytime soon since they are not
"urgent" (it seems). But I might get to them later, at the very least to
keep these cards working on trixie :).

Cheers.

-- System Information:
Debian Release: trixie/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 6.11.2-amd64 (SMP w/4 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_USER, TAINT_WARN, 
TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages broadcom-sta-dkms depends on:
ii  dkms  3.0.13-1

Versions of packages broadcom-sta-dkms recommends:
ii  wireless-tools  30~pre9-18

broadcom-sta-dkms suggests no packages.

-- no debconf information

Reply via email to