Package: radicale
Version: 3.2.3-1
Severity: normal
Tags: patch
Hi,
some suggestions to improve the README.Debian:
1.) Use consistent servername for uwsgi example.
debian/examples/apache2-vhost.conf has "Define _HOST event.${_DOMAIN}".
But in radicale.README.Debian there's "events.example.org.conf".
So my search for "events" to see where I had to set my servername failed.
For consistency and to keep the probably upstream-provided example
unchanged I suggest to remove the "s".
See attached 4_servername.patch.
2.) Enable Apache 2 headers module.
Without apache2 fails to start with apachectl error:
AH00526: Syntax error on line 53 of
/etc/apache2/conf-available/radicale-uwsgi.conf:
Invalid command 'RequestHeader', perhaps misspelled or defined by a
module not included in the server con[...]
See attached 5_a2enmod_headers.patch.
3.) DocumentRoot in debian/examples/apache2-vhost.conf
Currently you get:
apachectl warning:
AH00112: Warning: DocumentRoot [/var/www/nowhere] does not exist
I assume setting this to /var/lib/radicale/collections is the right
thing to do. Or maybe not? Would that even be a security issue?
Depending on that either change the path or add a hint to README.Debian
to ignore the warning. The former should probably be done upstream?
Thanks for maintaining radicale
Greets
jre
diff --git a/debian/radicale.README.Debian b/debian/radicale.README.Debian
index 0b866b6..72406e1 100644
--- a/debian/radicale.README.Debian
+++ b/debian/radicale.README.Debian
@@ -26,8 +26,8 @@ Setup, enable, and activate front-end service
(details on vhost and SSL/TLS certificate setup is not covered here):
a2enmod proxy_uwsgi ssl
- cp /usr/share/doc/radicale/examples/apache2-vhost.conf /etc/apache2/sites-available/events.example.org.conf
- a2ensite events.example.org.conf
+ cp /usr/share/doc/radicale/examples/apache2-vhost.conf /etc/apache2/sites-available/event.example.org.conf
+ a2ensite event.example.org.conf
service apache2 restart
diff --git a/debian/radicale.README.Debian b/debian/radicale.README.Debian
index 72406e1..a0f19c5 100644
--- a/debian/radicale.README.Debian
+++ b/debian/radicale.README.Debian
@@ -25,9 +25,9 @@ Enable and activate back-end uWSGI service:
Setup, enable, and activate front-end service
(details on vhost and SSL/TLS certificate setup is not covered here):
- a2enmod proxy_uwsgi ssl
cp /usr/share/doc/radicale/examples/apache2-vhost.conf /etc/apache2/sites-available/event.example.org.conf
a2ensite event.example.org.conf
+ a2enmod headers proxy_uwsgi ssl
service apache2 restart
