Package: radicale
Version: 3.2.3-1
Severity: normal
Tags: patch


Hi,

a few suggestions to update radicale's package dependencies and improve related documentation:


1.) Remove Suggests: libapache2-mod-proxy-uwsgi

Since at least buster (oldoldstable) libapache2-mod-proxy-uwsgi
was a transitional package, depending on apache2. It's unavailable in
trixie (testing). See
https://packages.debian.org/libapache2-mod-proxy-uwsgi

So this dependency (suggests) is not needed anymore and confusing. Please remove it and update the package description, see attached 1_libapache2-mod-proxy-uwsgi.patch. I verified that there are no other references to libapache2-mod-proxy-uwsgi.



2.) Add libapache2-mod-authnz-external to suggests.

This is mentioned in the README.Debian.

Attached 2_libapache2-mod-authnz-external.patch adds it to the package description and Suggests. I also added a hint that "PAM" relates to authenticating system users.



3.) Drop python3-passlib from suggests and clarify relevance of python3-bcrypt, explain PAM.

I /assume/ python3-passlib is needed both for password files (auth type htpasswd) and for PAM authentication (auth type remote_user), but am not sure about the latter one. python3-radicale already depends on it, at least if not built with the nocheck build profile. So you might just drop it from suggests and the package description. I'd be happy in blissful ignorance. IMO you don't have to explain an (indirect) Depends, and can ignore packages (I don't expect bugreports for those) built with a special build profile.

Further I /assume/ that python3-bcrypt is only needed with password files. (At my computer it's installed anyway due to unrelated dependencies.)

Attached 3_authentication.patch /might/ simplify the description and dependencies. Otherwise better documentation would be appreciated.



Thanks for maintaining radicale!

Greets
jre






-- System Information:
Debian Release: trixie/sid
   APT prefers testing
   APT policy: (990, 'testing'), (500, 'unstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 6.10.11-amd64 (SMP w/12 CPU threads; PREEMPT)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages radicale depends on:
ii  adduser                    3.137
ii  init-system-helpers        1.67
ii  lsb-base                   11.6
ii  python3                    3.12.6-1
ii  python3-radicale           3.2.3-1
ii  sysvinit-utils [lsb-base]  3.10-2

Versions of packages radicale recommends:
ii  ssl-cert  1.1.3

Versions of packages radicale suggests:
ii  apache2                     2.4.62-1
ii  apache2-utils               2.4.62-1
pn  libapache2-mod-proxy-uwsgi  <none>
ii  python3-bcrypt              4.2.0-1
ii  python3-passlib             1.7.4-4
ii  uwsgi                       2.0.26-4
ii  uwsgi-plugin-python3        2.0.26-4

-- Configuration Files:
/etc/radicale/config changed [not included]

-- no debconf information
diff --git a/debian/control b/debian/control
index b52c1ba..adbf601 100644
--- a/debian/control
+++ b/debian/control
@@ -44,7 +44,6 @@ Recommends:
 Suggests:
  apache2,
  apache2-utils,
- libapache2-mod-proxy-uwsgi,
  python3-bcrypt,
  python3-passlib,
  uwsgi,
@@ -71,7 +70,7 @@ Description: simple calendar and addressbook server - daemon
  Serving directly with uWSGI
  requires the packages uwsgi and uwsgi-plugin-python3.
  Serving with Apache as front-end and uWSGI only as middleware
- additionally requires the packages apache2 and libapache2-mod-proxy-uwsgi.
+ additionally requires the package apache2.
 
 Package: python3-radicale
 Section: python
diff --git a/debian/control b/debian/control
index adbf601..e657cb4 100644
--- a/debian/control
+++ b/debian/control
@@ -44,6 +44,7 @@ Recommends:
 Suggests:
  apache2,
  apache2-utils,
+ libapache2-mod-authnz-external,
  python3-bcrypt,
  python3-passlib,
  uwsgi,
@@ -61,6 +62,9 @@ Description: simple calendar and addressbook server - daemon
  .
  This package contains the radicale daemon.
  .
+ Using Apache with authentication of system users (PAM)
+ requires the package libapache2-mod-authnz-external.
+ .
  Creating encrypted password files
  require the package apache2-utils.
  .
diff --git a/debian/radicale.README.Debian b/debian/radicale.README.Debian
index e58a9e0..0b866b6 100644
--- a/debian/radicale.README.Debian
+++ b/debian/radicale.README.Debian
@@ -10,7 +10,7 @@ i.e. expects a front-end web service to resolve ${REMOTE_USER} via WSGI.
 ## Apache via uWSGI with PAM authentication
 
 Recommended setup for production use is to serve system-wide
-by Apache via uWSGI with Apache-based authenticating,
+by Apache via uWSGI with Apache-based authentication of system users (PAM),
 using the file /etc/radicale/config as main configuration file.
 
 Install needed packages:
diff --git a/debian/control b/debian/control
index e657cb4..7578a25 100644
--- a/debian/control
+++ b/debian/control
@@ -46,7 +46,6 @@ Suggests:
  apache2-utils,
  libapache2-mod-authnz-external,
  python3-bcrypt,
- python3-passlib,
  uwsgi,
  uwsgi-plugin-python3,
 Pre-Depends:
@@ -65,11 +64,9 @@ Description: simple calendar and addressbook server - daemon
  Using Apache with authentication of system users (PAM)
  requires the package libapache2-mod-authnz-external.
  .
- Creating encrypted password files
- require the package apache2-utils.
- .
- Stronger password hashes
- require the packages python3-passlib and python3-bcrypt.
+ Creating encrypted password files requires the package
+ apache2-utils, and for stronger password hashes the package
+ python3-bcrypt.
  .
  Serving directly with uWSGI
  requires the packages uwsgi and uwsgi-plugin-python3.

Reply via email to