Hi!

On Thu, Oct 03, 2024 at 11:12:06PM +0800, Bo YU wrote:
> On Fri, Apr 14, 2023 at 07:09:33PM +0200, наб wrote:
> > Version: 2.3-1
> > 
> > When running rush, freshly installed, I get this:
> > -- >8 --
> > Apr 14 18:59:10 szarotka rush[848]: parsing legacy configuration file 
> > /etc/rush.rc
> > Apr 14 18:59:10 szarotka rush[848]: debug level set to 1
> > Apr 14 18:59:10 szarotka rush[848]: /etc/rush.rc:34: unknown limit: 10r20
> > -- >8 --
> I have packaged rush 2.4[0], but I am not rush user in fact, could you help
> me to test it on your side to verify the rush 2.4 works fine or not[1]?
> [1]: http://vimer.7766.org:63015/rush/

FTR, I'm not a rush user either. Going by the date of the mail,
I was probably testing something on every shell. Happy to test though.

I built the 2.4-1 dsc, ran rush, saw
  Local configuration error occurred.
  Contact the systems administrator for further assistance.
and the journal said
-- >8 --
2024-10-03T17:40:20+0200 tarta rush[124041]: parsing legacy configuration file 
/etc/rush.rc
2024-10-03T17:40:20+0200 tarta rush[124041]: /etc/rush.rc:14: unknown 
statement: gitroot
2024-10-03T17:40:20+0200 tarta rush[124041]: /etc/rush.rc:15: unknown 
statement: lib64
2024-10-03T17:40:20+0200 tarta rush[124041]: /etc/rush.rc:16: unknown 
statement: All
2024-10-03T17:40:20+0200 tarta rush[124041]: /etc/rush.rc:28: unknown statement:
2024-10-03T17:40:20+0200 tarta rush[124041]: /etc/rush.rc:30: unknown 
statement: rush
2024-10-03T17:40:20+0200 tarta rush[124041]: /etc/rush.rc:31: unknown statement:
2024-10-03T17:40:20+0200 tarta rush[124041]: /etc/rush.rc:33: unknown 
statement: global
2024-10-03T17:40:20+0200 tarta rush[124041]: debug level set to 2
2024-10-03T17:40:20+0200 tarta rush[124041]: /etc/rush.rc:37: unknown statement:
2024-10-03T17:40:20+0200 tarta rush[124041]: /etc/rush.rc:41: unknown statement:
2024-10-03T17:40:20+0200 tarta rush[124041]: [56B blob data]
2024-10-03T17:40:20+0200 tarta rush[124041]: [38B blob data]
2024-10-03T17:40:20+0200 tarta rush[124041]: /etc/rush.rc:45: not a valid file 
mode
2024-10-03T17:40:20+0200 tarta rush[124041]: /etc/rush.rc:46: unknown 
statement: clrenv
2024-10-03T17:40:20+0200 tarta rush[124041]: /etc/rush.rc:47: unknown 
statement: keepenv
2024-10-03T17:40:20+0200 tarta rush[124041]: /etc/rush.rc:48: unknown 
statement: setenv
2024-10-03T17:40:20+0200 tarta rush[124041]: /etc/rush.rc:49: not an absolute 
directory name
2024-10-03T17:40:20+0200 tarta rush[124041]: /etc/rush.rc:56: unknown 
statement: fall-through
2024-10-03T17:40:20+0200 tarta rush[124041]: /etc/rush.rc:57: unknown statement:
2024-10-03T17:40:20+0200 tarta rush[124041]: /etc/rush.rc:61: unknown statement:
2024-10-03T17:40:20+0200 tarta rush[124041]: /etc/rush.rc:71: unknown statement:
2024-10-03T17:40:20+0200 tarta rush[124041]: /etc/rush.rc:73: unknown 
statement: match
2024-10-03T17:40:20+0200 tarta rush[124041]: /etc/rush.rc:74: unknown 
statement: ${-1}
2024-10-03T17:40:20+0200 tarta rush[124041]: /etc/rush.rc:78: unknown statement:
2024-10-03T17:40:20+0200 tarta rush[124041]: /etc/rush.rc:80: unknown statement:
2024-10-03T17:40:20+0200 tarta rush[124041]: /etc/rush.rc:82: unknown 
statement: match
2024-10-03T17:40:20+0200 tarta rush[124041]: /etc/rush.rc:84: unknown statement:
2024-10-03T17:40:20+0200 tarta rush[124041]: /etc/rush.rc:92: unknown statement:
2024-10-03T17:40:20+0200 tarta rush[124041]: /etc/rush.rc:94: unknown 
statement: match
2024-10-03T17:40:20+0200 tarta rush[124041]: /etc/rush.rc:96: not a valid file 
mode
2024-10-03T17:40:20+0200 tarta rush[124041]: /etc/rush.rc:98: unknown statement:
2024-10-03T17:40:20+0200 tarta rush[124041]: /etc/rush.rc:101: unknown 
statement:
2024-10-03T17:40:20+0200 tarta rush[124041]: /etc/rush.rc:103: unknown 
statement: match
2024-10-03T17:40:20+0200 tarta rush[124041]: /etc/rush.rc:104: unknown 
statement: ${-1}
2024-10-03T17:40:20+0200 tarta rush[124041]: /etc/rush.rc:107: not a valid file 
mode
2024-10-03T17:40:20+0200 tarta rush[124041]: /etc/rush.rc:109: unknown 
statement:
2024-10-03T17:40:20+0200 tarta rush[124041]: /etc/rush.rc:113: unknown 
statement:
2024-10-03T17:40:20+0200 tarta rush[124041]: /etc/rush.rc:117: unknown 
statement:
2024-10-03T17:40:20+0200 tarta rush[124041]: /etc/rush.rc:119: unknown 
statement: match
2024-10-03T17:40:20+0200 tarta rush[124041]: /etc/rush.rc:121: unknown 
statement: setenv
2024-10-03T17:40:20+0200 tarta rush[124041]: /etc/rush.rc:123: unknown 
statement:
2024-10-03T17:40:20+0200 tarta rush[124041]: /etc/rush.rc:128: unknown 
statement:
2024-10-03T17:40:20+0200 tarta rush[124041]: /etc/rush.rc:130: unknown 
statement: match
2024-10-03T17:40:20+0200 tarta rush[124041]: /etc/rush.rc:131: unknown 
statement: remopt
2024-10-03T17:40:20+0200 tarta rush[124041]: /etc/rush.rc:133: unknown 
statement: insert
2024-10-03T17:40:20+0200 tarta rush[124041]: /etc/rush.rc:134: unknown 
statement: insert
2024-10-03T17:40:20+0200 tarta rush[124041]: /etc/rush.rc:136: unknown 
statement:
2024-10-03T17:40:20+0200 tarta rush[124041]: /etc/rush.rc:141: unknown 
statement:
2024-10-03T17:40:20+0200 tarta rush[124041]: /etc/rush.rc:143: unknown 
statement: match
2024-10-03T17:40:20+0200 tarta rush[124041]: /etc/rush.rc:144: unknown 
statement: $1
2024-10-03T17:40:20+0200 tarta rush[124041]: /etc/rush.rc:148: unknown 
statement:
2024-10-03T17:40:20+0200 tarta rush[124041]: /etc/rush.rc:150: unknown 
statement:
2024-10-03T17:40:20+0200 tarta rush[124041]: /etc/rush.rc:152: unknown 
statement: match
2024-10-03T17:40:20+0200 tarta rush[124041]: errors in configuration file
-- >8 --

Presumably this is because /etc/rush.rc says
-- >8 --
$ head -n20 /etc/rush.rc | tail | cat -A
#                               is allowed by this config).  It should 
contain^M$
#                               at least the following directories:^M$
#                                  bin      cvsroot  dev       etc^M$
                                   gitroot  home     incoming  lib^M$
^I^I^I^I   lib64    svnroot  usr  var^M$
^I^I^I^IAll binaries are supposed to reside in bin.^M$
#    /srv/rush/home             Directory for hosting home directories^M$
#                               of users that are allowed to use the^M$
#                               chrooted service, as declared below.^M$
#^M$
-- >8 --
which (a) has a stray \r at the end of every line,
  and (b) is missing comments.

Now, some points I found while reviewing the 2.3-1 -> 2.4-1 debdiff itself.

rush-2.3/debian/changelog:
  +rush (2.4-1) UNRELEASED; urgency=medium
  +
  +  [ Debian Janitor ]
  +  ...
  +
  +  [ Bo YU ]
  +  * Update upstream sig
  +  ...
  +
  + -- Bo YU <tsu.y...@gmail.com>  Tue, 03 Sep 2024 11:58:10 +0800
  +
  +rush (2.3-2) unstable; urgency=medium
  +
  +  * Add metadata for debian/patch/*.
  +
  + -- Bo YU <tsu.y...@gmail.com>  Sat, 23 Jul 2022 09:18:16 +0800

But 2.3-2 doesn't exist in the archive (never uploaded?),
so you should move "Add metadata ..." to 2.4-1 and remove the 2.3-2 header.
(I'm assuming gbp dch tricked you here. Happens to my packages too sometimes.)

Also, the d/control Standards-Version: 4.7.0.1 probably should just be "4.7.0"
(not an error, this is allowed, but policy says there's no point to specifying 
the .1).

Your line in d/copyright should also say 2022-2024 instead of just 2024.

Best,

Attachment: signature.asc
Description: PGP signature

Reply via email to