Colin, Preamble...
Thank you for taking the time to prepare this package and your contribution to the Debian project. The review below is for assistance. This review is offered to help package submitters to Debian mentors inorder to improve their packages prior to possible sponsorship into Debian. There is no obligation on behalf of the submitter to make any alterations based upon information provided in the review. Fresh review based on new upload. Review... 1. Build: * pbuilder [1]: Good * sbuild [2]: Good 2. Lintian [3]: Issue W: qatlib-examples: groff-message an.tmac:<standard input>:38: warning: tbl preprocessor failed, or it or soelim was not run; table(s) likely not rendered (TE macro called with TW register undefined) [usr/share/man/man7/cpa_sample_code.7.gz:1] N: N: A manual page provoked warnings or errors from the man program. Here are N: some common ones: N: N: "cannot adjust" or "can't break" are issues with paragraph filling. They N: are usually related to long lines. Justifying text on the left hand side N: can help with adjustments. Hyphenation can help with breaks. N: N: For more information, please see "Manipulating Filling and Adjusting" and N: "Manipulating Hyphenation" in the Groff manual (see info groff). N: N: "can't find numbered character" usually means that the input was in a N: national legacy encoding. The warning means that some characters were N: dropped. Please use escapes such as \[:a] as described on the groff_char N: manual page. N: N: Other common warnings are formatting typos. String arguments to .IP N: require quotes. Usually, some text is lost or mangled. See the groff_man N: (or groff_mdoc if using mdoc) manual page for details on macros. N: N: The check for manual pages uses the --warnings option to man to catch N: common problems, like a . or a ' at the beginning of a line as literal N: text. They are interpreted as Groff commands. Just reformat the paragraph N: so the characters are not at the beginning of a line. You can also add a N: zero-width space (\&) in front of them. N: N: Aside from overrides, warnings can be disabled with the .warn directive. N: Please see "Debugging" in the Groff manual. N: N: You can see the warnings yourself by running the command used by Lintian: N: N: LC_ALL=C.UTF-8 MANROFFSEQ='' MANWIDTH=80 \ N: man --warnings -E UTF-8 -l -Tutf8 -Z <file> >/dev/null N: N: Please refer to the groff_man(7) manual page and the groff_mdoc(7) manual N: page for details. N: N: Visibility: warning N: Show-Always: no N: Check: documentation/manual N: Renamed from: manpage-has-errors-from-man I: qatlib-service: systemd-service-file-missing-documentation-key [usr/lib/systemd/system/qat.service] N: N: The systemd service file does not contain a Documentation key. N: N: Documentation for systemd service files can be automatically viewed using N: systemctl help servicename if this field is present. N: N: Please refer to the systemd.unit(5) manual page for details. N: N: Visibility: info N: Show-Always: no N: Check: systemd 3. Licenses [4]: Good 4. Watch file [uscan --force-download]: Good 5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Good 6. Reproducible builds [5]: Good 7. Install [No previous installs]: Not performed at this time 8. Upgrade [Over previous installs if any]: Not performed at this time Additional... A. autopkgtest failure autopkgtest ----------- autopkgtest [15:29:37]: starting date and time: 2024-09-25 15:29:37+0100 autopkgtest [15:29:37]: version 5.39 autopkgtest [15:29:37]: host ks-tarkin; command line: /usr/bin/autopkgtest /home/philwyett/Development/builder/debian/mentoring/qatlib_24.02.0- 1_amd64.changes -- schroot unstable-amd64-sbuild autopkgtest [15:29:38]: testbed dpkg architecture: amd64 autopkgtest [15:29:38]: testbed apt version: 2.9.8 autopkgtest [15:29:38]: testbed running kernel: Linux 6.10.9-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.10.9-1 (2024-09-08) autopkgtest [15:29:38]: @@@@@@@@@@@@@@@@@@@@ source /home/philwyett/Development/builder/debian/mentoring/qatlib_24.02.0-1.dsc dpkg-source: warning: extracting unsigned source package (/tmp/autopkgtest.bWce0r/qatlib_24.02.0-1.dsc) dpkg-source: info: extracting qatlib in src dpkg-source: info: unpacking qatlib_24.02.0.orig.tar.gz dpkg-source: info: unpacking qatlib_24.02.0-1.debian.tar.xz dpkg-source: info: using patch list from debian/patches/series dpkg-source: info: applying 0001-qat_init.sh-hard-code-system-service- path.patch dpkg-source: info: applying cpa_sample_code_manpage.patch dpkg-source: info: applying qat-init-man.patch dpkg-source: info: applying lac_ecsm2-fix-spelling-mistakes.patch dpkg-source: info: applying qat.service.in-fixup-for-renamed-qat_init.patch autopkgtest [15:29:38]: testing package qatlib version 24.02.0-1 autopkgtest [15:29:38]: build not needed autopkgtest [15:29:39]: test libqat-dev: preparing testbed Reading package lists... Building dependency tree... Reading state information... The following NEW packages will be installed: apt-utils 0 upgraded, 1 newly installed, 0 to remove and 0 not upgraded. Need to get 327 kB of archives. After this operation, 1114 kB of additional disk space will be used. Get:1 http://deb.debian.org/debian unstable/main amd64 apt-utils amd64 2.9.8 [327 kB] debconf: delaying package configuration, since apt-utils is not installed Fetched 327 kB in 0s (5383 kB/s) Selecting previously unselected package apt-utils. (Reading database ... 11782 files and directories currently installed.) Preparing to unpack .../apt-utils_2.9.8_amd64.deb ... Unpacking apt-utils (2.9.8) ... Setting up apt-utils (2.9.8) ... Get:1 file:/tmp/autopkgtest.bWce0r/binaries InRelease Ign:1 file:/tmp/autopkgtest.bWce0r/binaries InRelease Get:2 file:/tmp/autopkgtest.bWce0r/binaries Release [816 B] Get:2 file:/tmp/autopkgtest.bWce0r/binaries Release [816 B] Get:3 file:/tmp/autopkgtest.bWce0r/binaries Release.gpg Ign:3 file:/tmp/autopkgtest.bWce0r/binaries Release.gpg Get:4 file:/tmp/autopkgtest.bWce0r/binaries Packages [8692 B] Reading package lists... Reading package lists... Building dependency tree... Reading state information... Starting pkgProblemResolver with broken count: 0 Starting 2 pkgProblemResolver with broken count: 0 Done The following NEW packages will be installed: libqat-dev libqat4 libusdm-dev libusdm0 qatlib-examples qatlib-service 0 upgraded, 6 newly installed, 0 to remove and 0 not upgraded. Need to get 0 B/492 kB of archives. After this operation, 2208 kB of additional disk space will be used. Get:1 file:/tmp/autopkgtest.bWce0r/binaries libusdm0 24.02.0-1 [13.6 kB] Get:2 file:/tmp/autopkgtest.bWce0r/binaries libqat4 24.02.0-1 [194 kB] Get:3 file:/tmp/autopkgtest.bWce0r/binaries libqat-dev 24.02.0-1 [83.8 kB] Get:4 file:/tmp/autopkgtest.bWce0r/binaries libusdm-dev 24.02.0-1 [5348 B] Get:5 file:/tmp/autopkgtest.bWce0r/binaries qatlib-examples 24.02.0-1 [167 kB] Get:6 file:/tmp/autopkgtest.bWce0r/binaries qatlib-service 24.02.0-1 [28.9 kB] Selecting previously unselected package libusdm0. (Reading database ... 11864 files and directories currently installed.) Preparing to unpack .../0-libusdm0.deb ... Unpacking libusdm0 (24.02.0-1) ... Selecting previously unselected package libqat4. Preparing to unpack .../1-libqat4.deb ... Unpacking libqat4 (24.02.0-1) ... Selecting previously unselected package libqat-dev. Preparing to unpack .../2-libqat-dev.deb ... Unpacking libqat-dev (24.02.0-1) ... Selecting previously unselected package libusdm-dev. Preparing to unpack .../3-libusdm-dev.deb ... Unpacking libusdm-dev (24.02.0-1) ... Selecting previously unselected package qatlib-examples. Preparing to unpack .../4-qatlib-examples.deb ... Unpacking qatlib-examples (24.02.0-1) ... Selecting previously unselected package qatlib-service. Preparing to unpack .../5-qatlib-service.deb ... /var/lib/dpkg/tmp.ci/preinst: 7: groupadd: not found dpkg: error processing archive /tmp/apt-dpkg-install-EaZ4Vj/5-qatlib- service.deb (--unpack): new qatlib-service package pre-installation script subprocess returned error exit status 127 Errors were encountered while processing: /tmp/apt-dpkg-install-EaZ4Vj/5-qatlib-service.deb E: Sub-process /usr/bin/dpkg returned an error code (1) E: Failed to process build dependencies libqat-dev FAIL badpkg blame: arg:/home/philwyett/Development/builder/debian/mentoring/libqat- dev_24.02.0-1_amd64.deb deb:libqat-dev arg:/home/philwyett/Development/builder/debian/mentoring/libqat4- dbgsym_24.02.0-1_amd64.deb deb:libqat4-dbgsym arg:/home/philwyett/Development/builder/debian/mentoring/libqat4_24.02.0- 1_amd64.deb deb:libqat4 arg:/home/philwyett/Development/builder/debian/mentoring/libusdm-dev_24.02.0- 1_amd64.deb deb:libusdm-dev arg:/home/philwyett/Development/builder/debian/mentoring/libusdm0- dbgsym_24.02.0-1_amd64.deb deb:libusdm0-dbgsym arg:/home/philwyett/Development/builder/debian/mentoring/libusdm0_24.02.0- 1_amd64.deb deb:libusdm0 arg:/home/philwyett/Development/builder/debian/mentoring/qatlib-examples- dbgsym_24.02.0-1_amd64.deb deb:qatlib-examples-dbgsym arg:/home/philwyett/Development/builder/debian/mentoring/qatlib- examples_24.02.0-1_amd64.deb deb:qatlib-examples arg:/home/philwyett/Development/builder/debian/mentoring/qatlib-service- dbgsym_24.02.0-1_amd64.deb deb:qatlib-service-dbgsym arg:/home/philwyett/Development/builder/debian/mentoring/qatlib- service_24.02.0-1_amd64.deb deb:qatlib-service /home/philwyett/Development/builder/debian/mentoring/qatlib_24.02.0-1.dsc badpkg: Test dependencies are unsatisfiable. A common reason is that your testbed is out of date with respect to the archive, and you need to use a current testbed or run apt-get update or use -U. autopkgtest [15:29:41]: test qat-service: preparing testbed autopkgtest [15:29:42]: testbed dpkg architecture: amd64 autopkgtest [15:29:42]: testbed apt version: 2.9.8 Reading package lists... Building dependency tree... Reading state information... The following NEW packages will be installed: apt-utils 0 upgraded, 1 newly installed, 0 to remove and 0 not upgraded. Need to get 327 kB of archives. After this operation, 1114 kB of additional disk space will be used. Get:1 http://deb.debian.org/debian unstable/main amd64 apt-utils amd64 2.9.8 [327 kB] debconf: delaying package configuration, since apt-utils is not installed Fetched 327 kB in 0s (4821 kB/s) Selecting previously unselected package apt-utils. (Reading database ... 11782 files and directories currently installed.) Preparing to unpack .../apt-utils_2.9.8_amd64.deb ... Unpacking apt-utils (2.9.8) ... Setting up apt-utils (2.9.8) ... Get:1 file:/tmp/autopkgtest.bWce0r/binaries InRelease Ign:1 file:/tmp/autopkgtest.bWce0r/binaries InRelease Get:2 file:/tmp/autopkgtest.bWce0r/binaries Release [816 B] Get:2 file:/tmp/autopkgtest.bWce0r/binaries Release [816 B] Get:3 file:/tmp/autopkgtest.bWce0r/binaries Release.gpg Ign:3 file:/tmp/autopkgtest.bWce0r/binaries Release.gpg Get:4 file:/tmp/autopkgtest.bWce0r/binaries Packages [8692 B] Reading package lists... Reading package lists... Building dependency tree... Reading state information... Starting pkgProblemResolver with broken count: 0 Starting 2 pkgProblemResolver with broken count: 0 Done The following NEW packages will be installed: libqat-dev libqat4 libusdm-dev libusdm0 qatlib-examples qatlib-service 0 upgraded, 6 newly installed, 0 to remove and 0 not upgraded. Need to get 0 B/492 kB of archives. After this operation, 2208 kB of additional disk space will be used. Get:1 file:/tmp/autopkgtest.bWce0r/binaries libusdm0 24.02.0-1 [13.6 kB] Get:2 file:/tmp/autopkgtest.bWce0r/binaries libqat4 24.02.0-1 [194 kB] Get:3 file:/tmp/autopkgtest.bWce0r/binaries libqat-dev 24.02.0-1 [83.8 kB] Get:4 file:/tmp/autopkgtest.bWce0r/binaries libusdm-dev 24.02.0-1 [5348 B] Get:5 file:/tmp/autopkgtest.bWce0r/binaries qatlib-examples 24.02.0-1 [167 kB] Get:6 file:/tmp/autopkgtest.bWce0r/binaries qatlib-service 24.02.0-1 [28.9 kB] Selecting previously unselected package libusdm0. (Reading database ... 11864 files and directories currently installed.) Preparing to unpack .../0-libusdm0.deb ... Unpacking libusdm0 (24.02.0-1) ... Selecting previously unselected package libqat4. Preparing to unpack .../1-libqat4.deb ... Unpacking libqat4 (24.02.0-1) ... Selecting previously unselected package libqat-dev. Preparing to unpack .../2-libqat-dev.deb ... Unpacking libqat-dev (24.02.0-1) ... Selecting previously unselected package libusdm-dev. Preparing to unpack .../3-libusdm-dev.deb ... Unpacking libusdm-dev (24.02.0-1) ... Selecting previously unselected package qatlib-examples. Preparing to unpack .../4-qatlib-examples.deb ... Unpacking qatlib-examples (24.02.0-1) ... Selecting previously unselected package qatlib-service. Preparing to unpack .../5-qatlib-service.deb ... /var/lib/dpkg/tmp.ci/preinst: 7: groupadd: not found dpkg: error processing archive /tmp/apt-dpkg-install-1Dcfcr/5-qatlib- service.deb (--unpack): new qatlib-service package pre-installation script subprocess returned error exit status 127 Errors were encountered while processing: /tmp/apt-dpkg-install-1Dcfcr/5-qatlib-service.deb E: Sub-process /usr/bin/dpkg returned an error code (1) E: Failed to process build dependencies qat-service FAIL badpkg blame: arg:/home/philwyett/Development/builder/debian/mentoring/libqat- dev_24.02.0-1_amd64.deb deb:libqat-dev arg:/home/philwyett/Development/builder/debian/mentoring/libqat4- dbgsym_24.02.0-1_amd64.deb deb:libqat4-dbgsym arg:/home/philwyett/Development/builder/debian/mentoring/libqat4_24.02.0- 1_amd64.deb deb:libqat4 arg:/home/philwyett/Development/builder/debian/mentoring/libusdm-dev_24.02.0- 1_amd64.deb deb:libusdm-dev arg:/home/philwyett/Development/builder/debian/mentoring/libusdm0- dbgsym_24.02.0-1_amd64.deb deb:libusdm0-dbgsym arg:/home/philwyett/Development/builder/debian/mentoring/libusdm0_24.02.0- 1_amd64.deb deb:libusdm0 arg:/home/philwyett/Development/builder/debian/mentoring/qatlib-examples- dbgsym_24.02.0-1_amd64.deb deb:qatlib-examples-dbgsym arg:/home/philwyett/Development/builder/debian/mentoring/qatlib- examples_24.02.0-1_amd64.deb deb:qatlib-examples arg:/home/philwyett/Development/builder/debian/mentoring/qatlib-service- dbgsym_24.02.0-1_amd64.deb deb:qatlib-service-dbgsym arg:/home/philwyett/Development/builder/debian/mentoring/qatlib- service_24.02.0-1_amd64.deb deb:qatlib-service /home/philwyett/Development/builder/debian/mentoring/qatlib_24.02.0-1.dsc badpkg: Test dependencies are unsatisfiable. A common reason is that your testbed is out of date with respect to the archive, and you need to use a current testbed or run apt-get update or use -U. autopkgtest [15:29:44]: @@@@@@@@@@@@@@@@@@@@ summary libqat-dev FAIL badpkg blame: arg:/home/philwyett/Development/builder/debian/mentoring/libqat- dev_24.02.0-1_amd64.deb deb:libqat-dev arg:/home/philwyett/Development/builder/debian/mentoring/libqat4- dbgsym_24.02.0-1_amd64.deb deb:libqat4-dbgsym arg:/home/philwyett/Development/builder/debian/mentoring/libqat4_24.02.0- 1_amd64.deb deb:libqat4 arg:/home/philwyett/Development/builder/debian/mentoring/libusdm-dev_24.02.0- 1_amd64.deb deb:libusdm-dev arg:/home/philwyett/Development/builder/debian/mentoring/libusdm0- dbgsym_24.02.0-1_amd64.deb deb:libusdm0-dbgsym arg:/home/philwyett/Development/builder/debian/mentoring/libusdm0_24.02.0- 1_amd64.deb deb:libusdm0 arg:/home/philwyett/Development/builder/debian/mentoring/qatlib-examples- dbgsym_24.02.0-1_amd64.deb deb:qatlib-examples-dbgsym arg:/home/philwyett/Development/builder/debian/mentoring/qatlib- examples_24.02.0-1_amd64.deb deb:qatlib-examples arg:/home/philwyett/Development/builder/debian/mentoring/qatlib-service- dbgsym_24.02.0-1_amd64.deb deb:qatlib-service-dbgsym arg:/home/philwyett/Development/builder/debian/mentoring/qatlib- service_24.02.0-1_amd64.deb deb:qatlib-service /home/philwyett/Development/builder/debian/mentoring/qatlib_24.02.0-1.dsc badpkg: Test dependencies are unsatisfiable. A common reason is that your testbed is out of date with respect to the archive, and you need to use a current testbed or run apt-get update or use -U. qat-service FAIL badpkg blame: arg:/home/philwyett/Development/builder/debian/mentoring/libqat- dev_24.02.0-1_amd64.deb deb:libqat-dev arg:/home/philwyett/Development/builder/debian/mentoring/libqat4- dbgsym_24.02.0-1_amd64.deb deb:libqat4-dbgsym arg:/home/philwyett/Development/builder/debian/mentoring/libqat4_24.02.0- 1_amd64.deb deb:libqat4 arg:/home/philwyett/Development/builder/debian/mentoring/libusdm-dev_24.02.0- 1_amd64.deb deb:libusdm-dev arg:/home/philwyett/Development/builder/debian/mentoring/libusdm0- dbgsym_24.02.0-1_amd64.deb deb:libusdm0-dbgsym arg:/home/philwyett/Development/builder/debian/mentoring/libusdm0_24.02.0- 1_amd64.deb deb:libusdm0 arg:/home/philwyett/Development/builder/debian/mentoring/qatlib-examples- dbgsym_24.02.0-1_amd64.deb deb:qatlib-examples-dbgsym arg:/home/philwyett/Development/builder/debian/mentoring/qatlib- examples_24.02.0-1_amd64.deb deb:qatlib-examples arg:/home/philwyett/Development/builder/debian/mentoring/qatlib-service- dbgsym_24.02.0-1_amd64.deb deb:qatlib-service-dbgsym arg:/home/philwyett/Development/builder/debian/mentoring/qatlib- service_24.02.0-1_amd64.deb deb:qatlib-service /home/philwyett/Development/builder/debian/mentoring/qatlib_24.02.0-1.dsc badpkg: Test dependencies are unsatisfiable. A common reason is that your testbed is out of date with respect to the archive, and you need to use a current testbed or run apt-get update or use -U. E: Autopkgtest run failed. Certainly a 'groupadd' issue. B. 'debian/changelog' The normal entry for a new package would be the first line e.g. * Initial upload. (Closes: #1038726) Other lines below it can be removed. Summary... I believe qatlib is not yet ready for sponsorship at this time. Could the contributor rectify one of more of the raised issues. Once updated to your satisfaction and a new upload done, please remove the 'moreinfo' tag on the Request For Sponsorship (RFS) bug report. Regards Phil [1] pbuilder: * Command: sudo pbuilder build <PACKAGE>.dsc * Document: https://wiki.ubuntu.com/PbuilderHowto. * Document: https://wiki.debian.org/PbuilderTricks [2] sbuild: * Command: sbuild <PACKAGE>.dsc * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000002 * Document: https://wiki.debian.org/sbuild [3] lintian: * Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc, *.changes, *.buildinfo). Each can throw up different results, so be thorough. * Document: https://wiki.debian.org/Lintian [4] lrc: * Command: lrc * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon [5] reprotest * Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto- build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004 * Document: https://wiki.debian.org/ReproducibleBuilds/ * Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method -- "I play the game for the game’s own sake" Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans -- Buy Me A Coffee: https://buymeacoffee.com/kathenasorg Internet Relay Chat (IRC): kathenas Matrix: #kathenas:matrix.org Website: https://kathenas.org Instagram: https://instagram.com/kathenasorg/ Threads: https://www.threads.net/@kathenasorg --
signature.asc
Description: This is a digitally signed message part
