Control: tags -1 +moreinfo Andrea,
Preamble...
Thank you for taking the time to prepare this package and your contribution
to the Debian project.
The review below is for assistance. This review is offered to help package
submitters to Debian mentors inorder to improve their packages prior to
possible sponsorship into Debian. There is no obligation on behalf of the
submitter to make any alterations based upon information provided in the
review.
Review...
1. Build:
* pbuilder [1]: Good
* sbuild [2]: Good
2. Lintian [3]: Good
3. Licenses [4]: Good
4. Watch file [uscan --force-download]: N/A
5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Issue
[----------] 2 tests from SocketStream
[ RUN ] SocketStream.is_writable_UNIX
[ OK ] SocketStream.is_writable_UNIX (0 ms)
[ RUN ] SocketStream.is_writable_INET
../test/test.cc:189: Failure
Expected equality of these values:
0
::bind(s, reinterpret_cast<sockaddr *>(&addr), sizeof(addr))
Which is: -1
../test/test.cc:199: Failure
Expected equality of these values:
0
connect(s, reinterpret_cast<sockaddr *>(&addr), sizeof(addr))
Which is: -1
../test/test.cc:204: Failure
Expected: (disconnected_svr_sock) != (-1), actual: -1 vs -1
[ FAILED ] SocketStream.is_writable_INET (100 ms)
[----------] 2 tests from SocketStream (100 ms total)
6. Reproducible builds [5]: Issue, see 5.
7. Install [No previous installs]: Not performed at this time
8. Upgrade [Over previous installs if any]: Not performed at this time
Summary...
Thanks as always for submitting for review. Just one issue.
Once updated to your satisfaction and a new upload done, please remove the
'moreinfo' tag on the Request For Sponsorship (RFS) bug report.
Regards
Phil
[1] pbuilder:
* Command: sudo pbuilder build <PACKAGE>.dsc
* Document: https://wiki.ubuntu.com/PbuilderHowto.
* Document: https://wiki.debian.org/PbuilderTricks
[2] sbuild:
* Command: sbuild <PACKAGE>.dsc
* Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000002
* Document: https://wiki.debian.org/sbuild
[3] lintian:
* Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc,
*.changes, *.buildinfo). Each can throw up different results, so be thorough.
* Document: https://wiki.debian.org/Lintian
[4] lrc:
* Command: lrc
* Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon
[5] reprotest
* Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto-
build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild
* Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004
* Document: https://wiki.debian.org/ReproducibleBuilds/
* Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method
--
"I play the game for the game’s own sake"
Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans
--
Buy Me A Coffee: https://buymeacoffee.com/kathenasorg
Internet Relay Chat (IRC): kathenas
Matrix: #kathenas:matrix.org
Website: https://kathenas.org
Instagram: https://instagram.com/kathenasorg/
Threads: https://www.threads.net/@kathenasorg
--
signature.asc
Description: This is a digitally signed message part
