Hi Daniel,
I prepared a new patch to disable any GIT configuration made outside the git-
subepo project (system, global) to affect running the test suite.
Additionally ability to enable verbose running of test suite is prepared in
d/rules.
I did not made any 'changelog' modification yet.
Dne 07.09.2024 (sob) ob 19:22 +0200 je Daniel Gröber napisal(a):
> Hi Samo,
>
> You force-pushed again. I know I had notes on your commit hygene, but after
> uploading we're in maintanance mode now so you really must not do that. The
> notes were intended as feedback for future commits only.
>
> Luckily I hadn't pushed the three commit at issue on to salsa yet so no
> harm done -- and even if we could have handled it, but it's not
> proper. Just because I'm still in the middle of your git path to salsa
> there's no reason not to treat your repo as if it's the canonical one.
>
Yeah, i wont force push into my repo (if possible) while you pull from it. If
i.e. debian/git-subrepo changes in a way that i can not fast forward from it,
then i'll have to force-pull and consequently force push into may repo again.
Do you agree?
>
> Yeah the current testsuite setup is just not going to do. 1) We really have
> to override the user config to have any chance at reproducibility or make
> git-subrepo more robust in the face of things like this.
>
> 2) The testsuite quashes the error output that would have made debugging
> this trivial. There should be some kind of VERBOSE= toggle to get it when
> debugging. That's something to discuss with upstream.
>
> The current test setup is a mess so this is kind of difficult. The clean
> way to do it would be to remove the assumption that there is a pre-existing
> .git entirely, but that may make yet more upstream TODOs.
>
> One trick you can try to use is to override the git command in the
> test/setup script like so:
>
> git () { ENV=whatever command git -c 'some confg' "$@"; }
>
> read bash -c 'help command' if you're confused and note that shell
> functions have precedence over $PATH search. You can use this primitive to
> alleviate the leakage of ~/.gitconfig into the tests or just to move the
> .git dir in use to a tmp dir (cf. --git-dir or GIT_DIR envvar. See
> git.1). You can also override $HOME to get git to look in a different place
> for ~/.gitconfig. Much possibility, very wow.
>
> If all you end up needing is setting ENVvars ofc. a simple `export
> ENV=whatever` in test/setup would also do. Oh there's also
> GIT_CONFIG_GLOBAL so maybe the -c overrides aren't necessary.
>
Thanks for the GIT configuration tips. I hope this push addresses both points
above.
>
> eagerly awaiting more patches.
>
:)
best regards, Samo
