Hi Fabio,

On 10/09/2024 09:37, Fabio Fantoni wrote:
I found some files that I suppose could be added to the exclusions: spec and PKG-INFO

if you want take a look to this result and these files: https://salsa.debian.org/python-team/packages/bleachbit/-/jobs/6253106
Do you have any other package examples?
I'm reluctant to add more global excludes for single packages
(now we have package specific excludes) for fear of false negatives.

on another project I found also another possible exclusion: LICENSE

can produce false positives mainly in the case of GPL +/"or-later" and similar
Which project?
LICENSE was recently removed from the global excludes following a complaint of false negative.
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1078564


I also think it could be useful to have a parameter to add manual exclusions for some rare cases where it can report "false positives"
Please use debian/lrc.excludes as per my previous email.


as a last thing I suggest to add a variable on the salsa test to add any additional parameters to pass to the lrc command
I was wondering what the use case would be,
then realised that with 1.18 there is no way to use --spdx with Salsa CI!

Rather than start making changes to Salsa,
I think the best approach is to change debian/lrc.excludes to a general configuration file. File names do not usually start with a minus '-', so any needed options can just be added to this file. Probably change the name to lrc.config, but parse both for backwards compatibility.


Thanks for reporting these issues,
Regards,
Peter B

Reply via email to