Phil Wyett <philip.wy...@kathenas.org> writes: > Control: tags -1 +moreinfo > > Xiyue, > > Preamble... > > Thank you for taking the time to prepare this package and your contribution > to the Debian project. > > The review below is for assistance. This review is offered to help package > submitters to Debian mentors inorder to improve their packages prior to > possible sponsorship into Debian. There is no obligation on behalf of the > submitter to make any alterations based upon information provided in the > review. > > Review... > > 1. Build: > > * pbuilder [1]: Good > * sbuild [2]: Good > > 2. Lintian [3]: Good > > 3. Licenses [4]: Good > > 4. Watch file [uscan --force-download]: Issue > > philwyett@ks-tarkin:~/Development/builder/debian/mentoring/emacs-oauth2-0.17$ > uscan --force-download > uscan warn: Possible OpenPGP signature found at: > https://elpa.gnu.org/packages/oauth2-0.17.tar.sig > * Add opts=pgpsigurlmangle=s/$/.sig/ or opts=pgpmode=auto to debian/watch > * Add debian/upstream/signing-key.asc. > See uscan(1) for more details > uscan: error: tar is not a supported compression
Note that on GNU ELPA (GNU Emacs Lisp Package Archive) tar is the default option used by all packages. I think this can be considered as a restriction on uscan which should support tar. On the other hand, I'm mainly using uscan to check for new upstream version. The Salsa repository uses DEP14 recommended layout and doesn't use pristine-tar but tags and "git deborig" for generating the tarball for Debian archive (which will be in .tar.xz), so this is not an actual issue. Hope this helps clarify the situation :) > > 5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Good > > 6. Reproducible builds [5]: Good > > 7. Install [No previous installs]: Good > > 8. Upgrade [Over previous installs if any]: N/A > > Summary... > > I believe emacs-oauth2 is not yet ready for sponsorship at this time. Could > the contributor rectify one of more of the rasied issues. > > Once updated to your satisfaction and a new upload done, please remove the > 'moreinfo' tag on the Request For Sponsorship (RFS) bug report. > > Regards > > Phil > > [1] pbuilder: > > * Command: sudo pbuilder build <PACKAGE>.dsc > * Document: https://wiki.ubuntu.com/PbuilderHowto. > * Document: https://wiki.debian.org/PbuilderTricks > > [2] sbuild: > > * Command: sbuild <PACKAGE>.dsc > * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000002 > * Document: https://wiki.debian.org/sbuild > > [3] lintian: > > * Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc, > *.changes, *.buildinfo). Each can throw up different results, so be thorough. > * Document: https://wiki.debian.org/Lintian > > [4] lrc: > > * Command: lrc > * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon > > [5] reprotest > > * Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto- > build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild > * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004 > * Document: https://wiki.debian.org/ReproducibleBuilds/ > * Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method > > -- > > "I play the game for the game’s own sake" > > Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans > > -- > > Buy Me A Coffee: https://buymeacoffee.com/kathenasorg > > Internet Relay Chat (IRC): kathenas > > Matrix: #kathenas:matrix.org > > Website: https://kathenas.org > > Instagram: https://instagram.com/kathenasorg/ > > Threads: https://www.threads.net/@kathenasorg -- Xiyue Deng
signature.asc
Description: PGP signature
