Hello Jonathan, On 04/09/2024 14:51, Jonathan Carter wrote:
While preparing a MR for supporting dracut instead of initramfs-tools for live-build, I've noticed that Calamares requires 'rsync' which was not available in the images that I have locally generated.The executable rsync is called here: https://sources.debian.org/src/calamares/3.3.9-1/src/modules/unpackfs/main.py/#L179 Can you add rsync to the Depends list of calamares?Calamares itself doesn't rely on the unpackfs in order to function, for example, someone might use it as a rescue system, OEM setup tool, or even in installations use a mode that doesn't depend on rsync (like using a bootstrap tool, for example). > I could add it as a dependency for calamares-settings-debian, or even add it as a recommends for Calamares, but first I'd like more details on what you're doing. What are you doing in an initramfs or in dracut that uses Calamares? Are you building an initial ramdisk that contains Calamares?
Agreed. Since Calamares itself does not enforce the usage of the unpackfs module, the dependency on rsync belongs in calamares-settings-debian, which unpacks the squashfs image of the live system.
I have a MR ready (https://salsa.debian.org/live-team/live-build/-/merge_requests/353) which generates a live image using dracut instead of initramfs-tools. Within the MR I patch the settings for Calamares to fit the different path that dracut uses (see 5050-dracut.hook.chroot)
With dracut active, there is no need for live-boot, which brings in rsync (https://packages.debian.org/sid/live-boot). So up till now, rsync always has been present, and the dependency of the calamares installer was implicit instead of explicit.
I think that calamares-settings-debian is the best place to bring the dependency of rsync.
With kind regards, Roland Clobus
thanks, -Jonathan
OpenPGP_signature.asc
Description: OpenPGP digital signature
