Hi.

The bad thing about this build failure is that it's unconditional,
i.e. it is a failure in the tests but it does not go away by setting
DEB_BUILD_OPTIONS=nocheck. Anybody who tries to build this package
from source and retries with nocheck when it fails will see that
it still fails.

So, I wonder if the attached patch is acceptable for bullseye, given that
the window for the last point release is closing this weekend.

Rationale: If we are not going to fix the tests when they fail, then
it does not make sense to make the whole package build to fail because
of the tests.

Cc: involved parties

Thanks.
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
+magit (2.99.0.git0957.ge8c7bd03-1+deb11u1) bullseye; urgency=medium
+
+  * Non-maintainer upload.
+  * Make test failures non-fatal. Closes: #1070937.
+
+ -- Santiago Vila <sanv...@debian.org>  Sat, 24 Aug 2024 01:40:00 +0200
+
 magit (2.99.0.git0957.ge8c7bd03-1) unstable; urgency=medium
 
   [ Rémi Vanicat ]
--- a/debian/rules
+++ b/debian/rules
@@ -21,7 +21,7 @@ override_dh_auto_install:
        @echo do not run make install
 
 override_dh_elpa_test:
-       make test
+       make test || true
 
 override_dh_clean:
        dh_clean

Reply via email to