Package: release.debian.org
Severity: normal
Tags: bullseye
User: release.debian....@packages.debian.org
Usertags: pu
X-Debbugs-Cc: mlp...@packages.debian.org, debian-ocaml-ma...@lists.debian.org,
glo...@debian.org, sanv...@debian.org
Control: affects -1 + src:mlpost
[ Reason ]
This upload fixes FTBFS bug #991060, which is probably the last
remaining build failure due to a new imagemagick version which
was introduced late during the development stage of bullseye.
[ Impact ]
Without this upload, package will continue to FTBFS in bullseye.
[ Tests ]
I've checked that the package builds again and its contents (debdiff)
has not changed.
[ Risks ]
Low risk, the changes affect the way an image is converted during the build.
There is only a funny change in the Provides of libmlpost-ocaml-dev,
as detected by debdiff:
Provides: [-libmlpost-ocaml-dev-38o49-] {+libmlpost-ocaml-dev-qovj6+}
This is clearly generated automatically, and no Debian package has a reference
to such virtual package name. The worst thing that may happen is that anybody
privately relying on such virtual package name would have to rebuild it, but
compared
to us not honoring the DFSG by providing a package which does not build from
source, we should probably not worry about that.
[ Checklist ]
[X] *all* changes are documented in the d/changelog
[X] I reviewed all changes and I approve them
[X] attach debdiff against the package in (old)stable
[X] the issue is verified as fixed in unstable
[ Changes ]
Fix FTBFS bug by applying patch from Dennis Filder to override ImageMagick
policy.
[ Other info ]
I'll wait 24h-48h at most before upload just in case the maintainers would like
to put this in salsa and become the (formal) author of the changes.diff -Nru mlpost-0.8.2/debian/changelog mlpost-0.8.2/debian/changelog
--- mlpost-0.8.2/debian/changelog 2020-07-28 10:43:05.000000000 +0200
+++ mlpost-0.8.2/debian/changelog 2024-08-22 14:00:00.000000000 +0200
@@ -1,3 +1,11 @@
+mlpost (0.8.2-4+deb11u1) bullseye; urgency=medium
+
+ * Non-maintainer upload.
+ * Apply patch by Dennis Filder to override ImageMagick policy.
+ Closes: #991060.
+
+ -- Santiago Vila <sanv...@debian.org> Thu, 22 Aug 2024 14:00:00 +0200
+
mlpost (0.8.2-4) unstable; urgency=medium
* Add empty dh_dwz override to fix FTBFS
diff -Nru mlpost-0.8.2/debian/patches/0009-Override-ImageMagick-policy.patch
mlpost-0.8.2/debian/patches/0009-Override-ImageMagick-policy.patch
--- mlpost-0.8.2/debian/patches/0009-Override-ImageMagick-policy.patch
1970-01-01 01:00:00.000000000 +0100
+++ mlpost-0.8.2/debian/patches/0009-Override-ImageMagick-policy.patch
2024-08-22 13:58:50.000000000 +0200
@@ -0,0 +1,27 @@
+Description: Override ImageMagick policy
+ Derive an appropriate policy from the too strict default one.
+Author: Dennis Filder <d.fil...@web.de>
+Last-Update: 2021-07-16
+Bug-Debian: https://bugs.debian.org/991060
+
+--- a/ocamlbuild.Makefile
++++ b/ocamlbuild.Makefile
+@@ -44,6 +44,7 @@
+ EXTDLL = .so
+ DLL := backend/dllmlpost_ft$(EXTDLL) backend/libmlpost_ft.a
+
++POLFILE = "/etc/$(shell convert -version|sed -n '/^Version: /s@Version:
ImageMagick \([[:digit:]]\+\)\..*@ImageMagick-\1@p')"/policy.xml
+
+ ifeq "$(OCAMLBEST)" "opt"
+ all:
+@@ -195,7 +196,10 @@
+ .PHONY: doc
+ doc:
+ rm -f doc
++ test -d $(HOME)/.magick || mkdir -p $(HOME)/.magick
++ sed -e '/<policy domain="coder" rights="none" pattern="PS"
.>/s@"none"@"read|write"@' $(POLFILE) > $(HOME)/.magick/policy.xml
+ $(OCAMLBUILD) doc/index.html
++ rm -Rf $(HOME)/.magick
+ ln -s _build/doc doc
+
+ # clean
diff -Nru mlpost-0.8.2/debian/patches/series mlpost-0.8.2/debian/patches/series
--- mlpost-0.8.2/debian/patches/series 2020-07-28 10:43:05.000000000 +0200
+++ mlpost-0.8.2/debian/patches/series 2024-08-22 13:58:50.000000000 +0200
@@ -6,3 +6,4 @@
0006-Bitstring-now-uses-str.patch
0007-Adjust-myocamlbuild-to-use-cppo-and-ppx.patch
0008-The-bitstring-library-now-needs-str.patch
+0009-Override-ImageMagick-policy.patch
