Source: ltrace
Version: 0.7.3-git20240814-0.2
Severity: important
Tags: ftbfs patch
User: debian-ri...@lists.debian.org
Usertags: riscv64
X-Debbugs-Cc: debian-ri...@lists.debian.org

Dear Maintainer,

ltrace has a ftbfs issue on riscv64:

```
regs.c:31:9: error: implicit declaration of function 'perror' 
[-Wimplicit-function-declaration]
   31 |         perror("riscv64_read_gregs");
      |         ^~~~~~
make[5]: *** [Makefile:440: regs.lo] Error 1
make[5]: *** Waiting for unfinished jobs....
plt.c: In function 'arch_elf_init':
plt.c:62:9: error: implicit declaration of function 'fprintf' 
[-Wimplicit-function-declaration]
   62 |         fprintf(stderr, "failed: only LP64D ABI supported\n");
      |         ^~~~~~~
plt.c:30:1: note: include '<stdio.h>' or provide a declaration of 'fprintf'
   29 | #include "trace.h"
  +++ |+#include <stdio.h>
   30 | 
plt.c:62:9: warning: incompatible implicit declaration of built-in function 
'fprintf' [-Wbuiltin-declaration-mismatch]
   62 |         fprintf(stderr, "failed: only LP64D ABI supported\n");
      |         ^~~~~~~
plt.c:62:9: note: include '<stdio.h>' or provide a declaration of 'fprintf'
plt.c:62:17: error: 'stderr' undeclared (first use in this function)
   62 |         fprintf(stderr, "failed: only LP64D ABI supported\n");
      |                 ^~~~~~
plt.c:62:17: note: 'stderr' is defined in header '<stdio.h>'; this is probably 
fixable by adding '#include <stdio.h>'
```

Full buildd log please to see:
https://buildd.debian.org/status/fetch.php?pkg=ltrace&arch=riscv64&ver=0.7.3%2Bgit20240814-0.2&stamp=1723680864&raw=0

This is very easy to fix it and I have prepared one patch to fix this,
could you apply it on next upload? thanks.


-- 
Regards,
--
  Bo YU

diff -Nru ltrace-0.7.3+git20240814/debian/changelog 
ltrace-0.7.3+git20240814/debian/changelog
--- ltrace-0.7.3+git20240814/debian/changelog   2024-08-15 05:38:24.000000000 
+0800
+++ ltrace-0.7.3+git20240814/debian/changelog   2024-08-16 18:20:33.000000000 
+0800
@@ -1,3 +1,10 @@
+ltrace (0.7.3+git20240814-0.3) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix ftbfs on riscv64. (Closes: #-1)
+
+ -- Bo YU <tsu.y...@gmail.com>  Fri, 16 Aug 2024 18:20:33 +0800
+
 ltrace (0.7.3+git20240814-0.2) unstable; urgency=medium
 
   * Non-maintainer upload.
diff -Nru ltrace-0.7.3+git20240814/debian/patches/fix-riscv64-ftbfs.patch 
ltrace-0.7.3+git20240814/debian/patches/fix-riscv64-ftbfs.patch
--- ltrace-0.7.3+git20240814/debian/patches/fix-riscv64-ftbfs.patch     
1970-01-01 08:00:00.000000000 +0800
+++ ltrace-0.7.3+git20240814/debian/patches/fix-riscv64-ftbfs.patch     
2024-08-16 18:20:27.000000000 +0800
@@ -0,0 +1,27 @@
+Description: fix ftbfs on riscv64
+Author: Bo YU <tsu.y...@gmail.com>
+Forwarded: https://gitlab.com/cespedes/ltrace/-/merge_requests/23
+Last-Update: 2024-08-16
+---
+This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
+--- a/sysdeps/linux-gnu/riscv64/plt.c
++++ b/sysdeps/linux-gnu/riscv64/plt.c
+@@ -18,6 +18,7 @@
+  * 02110-1301 USA
+  */
+ 
++#include <stdio.h>
+ #include <sys/uio.h>
+ #include <gelf.h>
+ #include "ltrace-elf.h"
+--- a/sysdeps/linux-gnu/riscv64/regs.c
++++ b/sysdeps/linux-gnu/riscv64/regs.c
+@@ -18,6 +18,8 @@
+  * 02110-1301 USA
+  */
+ 
++#include <errno.h>
++#include <stdio.h>
+ #include <sys/uio.h>
+ #include "proc.h"
+ #include "ptrace.h"
diff -Nru ltrace-0.7.3+git20240814/debian/patches/series 
ltrace-0.7.3+git20240814/debian/patches/series
--- ltrace-0.7.3+git20240814/debian/patches/series      1970-01-01 
08:00:00.000000000 +0800
+++ ltrace-0.7.3+git20240814/debian/patches/series      2024-08-16 
17:31:39.000000000 +0800
@@ -0,0 +1 @@
+fix-riscv64-ftbfs.patch

Attachment: signature.asc
Description: PGP signature

Reply via email to