Hi Andreas,

On Wed, Aug 14, 2024 at 02:39:24PM -0300, Andreas Hasenack wrote:
> Package: jupyter-client
> Version: 8.6.2-2
> Priority: normal
> 
> Dear Maintainer,
> 
> jupyter-client's dep8 tests invoke /sbin/ifconfig. This binary comes
> from the bin:net-tools package, which in ubuntu is priority optional,
> and in debian is priority important.

> [...]
> 420s /usr/lib/python3.12/subprocess.py:1955: FileNotFoundError
> 
> In Debian this is likely not a problem (yet?), and the test passes.
> [...]
> Since this is the only delta between ubuntu and debian, I would kindly
> ask you to please also add this to the debian package. At first
> glance, it's not necessary, but it seems more correct.

Thanks for raising this!  What a surprise - I hadn't realised this
problem.  But I'm not sure about the proposed patch: jupyter-client
itself calls ifconfig (in jupyter_client/localinterfaces.py), so it
might be better to have this dependency be part of the binary package
itself rather than just part of the test suite.

If this isn't needed (have a read of the code in that file - it will
not fail is ifconfig is not found, just that some functionality will
be lost), and it's just that the test is failing, then your patch
would be fine.

What do you think?

Best wishes,

   Julian

Reply via email to