Andrea, The package looks to be in good shape. I just have a few small comments that I would like you to address before sponsoring it.
1. markdown source: quilt-patch-missing-description [debian/patches/ debian.patch] Could you please add a description to this patch? You can see an example at: https://salsa.debian.org/cryptocoin-team/electrum/-/blob/master/debian/ patches/Use-system-JavaScript-files.patch?ref_type=heads 2. I: markdown source: upstream-metadata-missing-repository [debian/upstream/ metadata] I’m assuming this is because the upstream doesn’t have a repository, just a tarball download (the little investigation I did indicated that might be true). If that is the case, please override this lintian tag with a description in the comment as to why. 3. P: markdown source: silent-on-rules-requiring-root [debian/control] I am assuming your program doesn’t require root to build (few do). If so, please add the line “Rules-Requires-Root: no” to debian/control. You can see an example at: https://salsa.debian.org/cryptocoin-team/electrum/-/blob/master/debian/ control?ref_type=heads 4. It might be nice to include an explanation in the binary package description that this is the original markdown program and some indication of how this relates to other implementations and under which circumstances someone would like to install this compared to other versions. This is optional and I leave it up to your discretion if you would like to do so and how it would be best worded. Soren On Monday, August 12, 2024 12:27:30 PM MST Soren Stoutner wrote: > Control: owner -1 ! > > Andrea, > > I will take a look at sponsoring the package. > > Soren > > On Monday, August 12, 2024 12:12:22 PM MST Bastian Germann wrote: > > Am 12.08.24 um 13:30 schrieb Andrea Pappacoda: > > > Hi Daniel and Bastian, is there anything I can do to move this forward? > > I'd > > > > prefer to avoid keeping the RM bug open for too long. > > > > I am not going to sponsor this. But I do not object to some other DD > > sponsoring it. -- Soren Stoutner so...@debian.org
signature.asc
Description: This is a digitally signed message part.