Control: tag -1 patch

On Wed, Jul 03, 2024 at 12:32:17PM +0000, Matthias Klose wrote:
> Package: src:libace-perl
> Version: 1.92-11
> Severity: important
> Tags: sid trixie
> User: debian-...@lists.debian.org
> Usertags: ftbfs-gcc-14

> RPC.xs: In function ‘constant’:
> RPC.xs:157:13: error: ‘return’ with no value, in function returning non-void 
> [-Wreturn-mismatch]
>   157 |             return _ACECLIENT_;
>       |             ^~~~~~
> RPC.xs:24:1: note: declared here
>    24 | constant(name, arg)
>       | ^~~~~~~~
> make[3]: *** [Makefile:327: RPC.o] Error 1

_ACECLIENT_ is an include guard with no value, it makes
no sense to treat it as a constant.

The attached patch from Gentoo ( https://bugs.gentoo.org/637330 )
fixes the build for me.

Hope this helps,
-- 
Niko Tyni   nt...@debian.org
>From 80cf7625e21decb91db6b75ce8c5efbb16c7396a Mon Sep 17 00:00:00 2001
From: Anton Molyboha <anton.stay.connec...@gmail.com>
Date: Fri, 10 Nov 2017 17:37:54 -0500
Subject: [PATCH] Fix compile with newer gcc "non-void function 'constant'
 should ..."

Bug: https://bugs.gentoo.org/637330
Bug: https://rt.cpan.org/Ticket/Display.html?id=123593
---
 RPC/RPC.xs | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/RPC/RPC.xs b/RPC/RPC.xs
index 3e059c0..cd4f6fa 100644
--- a/RPC/RPC.xs
+++ b/RPC/RPC.xs
@@ -152,12 +152,6 @@ int arg;
     case 'Z':
 	break;
     case '_':
-	if (strEQ(name, "_ACECLIENT_"))
-#ifdef _ACECLIENT_
-	    return _ACECLIENT_;
-#else
-	    goto not_there;
-#endif
 	break;
     }
     errno = EINVAL;
-- 
2.45.2

Reply via email to