Martin,

Preamble...

Thank you for taking the time to prepare this package and your contribution
to the Debian project.

The review below is for assistance. This review is offered to help package
submitters to Debian mentors inorder to improve their packages prior to
possible sponsorship into Debian. There is no obligation on behalf of the
submitter to make any alterations based upon information provided in the
review.

Review...

1. Build:

  * pbuilder [1]: Good
  * sbuild [2]: Good

2. Lintian [3]: Issue

'Standards-Version' in 'debian/control' requires updating to latest 4.7.0.

Ref: https://www.debian.org/doc/debian-policy/

3. Licenses [4]: Good

4. Watch file [uscan --force-download]: Good

5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Good

6. Reproducible builds [5]: Issue

Key log piece:

not ok ✗ test_block_23
# out> --- /tmp/190533/expected_output23        2024-08-04
23:10:29.462591653 +1400
# out> +++ /tmp/190533/test_output23    2024-08-04 23:10:29.454591169 +1400
# out> @@ -1 +1 @@
# out> -environment: line 1: _ps: command not found
# out> +environment: ligne 1: _ps: käsku ei ole
# test_doc.sh:27:test_block_23()

7. Install [No previous installs]: Good

8. Upgrade [Over previous installs if any]: N/A

Summary...

I believe bash-unit is not yet ready for sponsorship/upload. Could the
contributor rectify one of more of the rasied issues. Once updated to your
satisfaction and a new upload done, please remove the 'moreinfo' on the
Request For Sponsorship (RFS) bug report.

Note: Please remember to remove "moreinfo" tag when doing a new upload.

Command: bts tags <BUG_NUMBER> - moreinfo

Regards

Phil

[1] pbuilder:

  * Command: sudo pbuilder build <PACKAGE>.dsc
  * Document: https://wiki.ubuntu.com/PbuilderHowto.
  * Document: https://wiki.debian.org/PbuilderTricks

[2] sbuild:

  * Command: sbuild <PACKAGE>.dsc
  * Document: https://wiki.debian.org/sbuild

[3] lintian:

  * Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc,
*.changes, *.buildinfo). Each can throw up different results, so be thorough.
  * Document: https://wiki.debian.org/Lintian

[4] lrc:

  * Command: lrc -t
  * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon

[5] reprotest

  * Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto-
build <PACKAGE>dsc -- schroot unstable-amd64-sbuild
  * Document: https://wiki.debian.org/ReproducibleBuilds/
  * Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method

-- 

"I play the game for the game’s own sake"

Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans

--

Buy Me A Coffee: https://buymeacoffee.com/kathenasorg

Internet Relay Chat (IRC): kathenas

Matrix: #kathenas:matrix.org

Website: https://kathenas.org

Instagram: https://instagram.com/kathenasorg/

Threads: https://www.threads.net/@kathenasorg

--






Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to