On 28 July 2024 at 15:11, Cottrell, Allin wrote:
| On Sun, Jul 28, 2024 at 1:29 PM Dirk Eddelbuettel <e...@debian.org> wrote:
| >
| >
| > On 28 July 2024 at 18:27, Lucas Nussbaum wrote:
| > | Source: gretl
| > | Version: 2024b-1
| > | Severity: serious
| > | Justification: FTBFS
| > | Tags: trixie sid ftbfs
| > | User: lu...@debian.org
| > | Usertags: ftbfs-20240727 ftbfs-trixie
| > |
| > | Hi,
| > |
| > | During a rebuild of all packages in sid, your package failed to build
| > | on amd64.
| > |
| > |
| > | Relevant part (hopefully):
| > | > ../libtool --mode=compile gcc -fopenmp -c -g -O2
-Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=.
-fstack-protector-strong -fstack-clash-protection -Wformat
-Werror=format-security -fcf-protection -D_REENTRANT -I.. -I.. -I../lib/src
-I/usr/include/libxml2 -I/usr/include/glib-2.0
-I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/sysprof-6 -pthread
-I/usr/share/R/include -I/usr/lib/x86_64-linux-gnu/openmpi/include
-DHAVE_CONFIG_H -DLIBDIR=\"/usr/lib\" -o interact.lo ../lib/src/interact.c
| > | > libtool: compile: gcc -fopenmp -c -g -O2
-Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=.
-fstack-protector-strong -fstack-clash-protection -Wformat
-Werror=format-security -fcf-protection -D_REENTRANT -I.. -I.. -I../lib/src
-I/usr/include/libxml2 -I/usr/include/glib-2.0
-I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/sysprof-6 -pthread
-I/usr/share/R/include -I/usr/lib/x86_64-linux-gnu/openmpi/include
-DHAVE_CONFIG_H -DLIBDIR=\"/usr/lib\" ../lib/src/interact.c -fPIC -DPIC -o
.libs/interact.o
| > | > ../lib/src/interact.c: In function 'open_append_stage_1':
| > | > ../lib/src/interact.c:2131:19: error: implicit declaration of function
'try_http' [-Wimplicit-function-declaration]
| > | > 2131 | err = try_http(cmd->param, op->fname, NULL);
| > | > | ^~~~~~~~
| > | > make[2]: *** [Makefile:327: interact.lo] Error 1
| >
| > That looks like one of the simple issues where the newer compiler (and I
| > checked that this was gcc-14) is pickier about includes.
| >
| > Allin: Have you seen this already upstream, and better still, fixed already?
|
| Hmm, try_http() is declared in lib/src/gretl_www.h, which is included
| in interact.c provided that USE_CURL is defined. And in a full build
| of gretl I'd expect USE_CURL to be defined; without that we drop all
| internet interaction. I guess it's a bug that the call to try_http()
| in interact.c is not itself guarded by USE_CURL, and that's now done
| in git. If that doesn't solve the problem, the question that arises is
| why USE_CURL is (apparently) not getting defined.
Good catch, and analysis.
We always turn curl on in the Debian builds. I have a build-depends on
libcurl4-gnutls-dev | libcurl4-dev
and the libgretl package depends on
libcurl3t64-gnutls (>= 7.56.1)
(where thr t64 suffix is for a Debian-internal transition we did to become
'year 2038' resistant by switching to 'bigger' time types).
So that sounds like you spot on that maybe the file in question did not have
#define guards, the older compiler was tolerant but gcc-14 nags?
Dirk
--
dirk.eddelbuettel.com | @eddelbuettel | e...@debian.org
