Hi Soren
Sorry for the delay in replying, I decided to take action as soon as I
saw the message. Now, forks to the spaghetti:
THINGS THAT NEED TO BE ADDRESSED BEFORE SPONSORSHIP
1. Your debian/control file specifies:
Rules-Requires-Root: binary-targets
This is used when the binary targets require root during build time
(as contrasted with install time). It is quite rare to need this. If
your program does need root during build time that is fine. But I
would like to understand why before sponsoring the package.
I changed it to Rules-Requires-Root: no
2. Your debian/postinst creates:
/home/$install_user/.config/baby/baby.conf
at installation time. Typically this is done at runtime. Otherwise,
only the person who installs the package will have the file created.
Other users on the system will not.
I would recommend that you move the logic for creating this file to
your runtime program, so that any user who runs the program will have
~/.config/baby/baby.conf created.
If for some reason I have misunderstood what is happening, just
explain it to me and I can sponsor it as currently packaged.
This is a very important observation. The configuration file is now
created at runtime and the debian/postinst is no more needed. This lets
any user run Baby on the hypothetical multiuser system.
3. Your debian/upstream/metadata contains four of the same URLs, and
they point to the Debian packaging repository. These should point to
the upstream repository, and it would be nice if they were more
direct, like this:
Bug-Database: https://github.com/manuwarfare/baby/issues
Bug-Submit: https://github.com/manuwarfare/baby/issues/new
Repository: https://github.com/manuwarfare/baby.git
Repository-Browse: https://github.com/manuwarfare/baby
Changed according to recommendations. Nothing more to say :-)
COMMENTS THAT DON’T NEED TO BE ADDRESSED BEFORE SPONSORSHIP
1. Your debian/sources contains both options and local-options with
similar content. Looking at the instructions it would appear that you
only need options.
https://www.debian.org/doc/manuals/maint-guide/dother.en.html#sourcel
But if for some reason you need both that is OK.
I leave only options that is the one needed.
2. You have debian/baby.install, which works fine. If you have
multiple binaries you use binary-name.install for each install file.
But as you have only one binary, you can just use debian/install if
you like.
Changed to debian/install
Note: I've been reading Gregor and Yavor's posts with the other
suggestions about this, but since you're the potential sponsor I'd
rather wait for your final recommendation.
Greetings,
Manuel
--
GPG signature
<https://keys.openpgp.org/vks/v1/by-fingerprint/ECA5016D963F871E5873CFC2E573B97D48F2E520>
