Bug#1059341: gir1.2-cscreensaver-1.0: contains 900K of GIR XML which shouldn't usually be necessary on end user systems

[Fabio Fantoni]

Il 09/07/2024 12:58, Simon McVittie ha scritto:

On Tue, 09 Jul 2024 at 12:32:22 +0200, Fabio Fantoni wrote:

Il 22/12/2023 23:26, Simon McVittie ha scritto:

On #1057391, Fabio Fantoni wrote:

user testing cinnamon 6 on sid spotted -dev package in
gir1.2-cscreensaver-1.0 actually not present, so I suppose added from recent
dh_girepository changes. upstream have all in libcscreensaver0, so I created
at least gir1.2-cscreensaver-1.0 in 5.4.1-2 to solve the policy issue (I not
tried to do a PR for upstream now) but I put also gir file in it instead
create -dev package for only it. I must create gir1.2-cscreensaver-1.0-dev
with gir and all needed -dev deps or is possible remove the -dev deps?

If I'm understanding the question correctly, the right answer depends
on whether this is a public or private library.

Hi, I tried to report this upstream but in new version instead make the
library "fully public" or "fully private" have simply removed thr gir file: 
https://github.com/linuxmint/cinnamon-screensaver/commit/97fcf5d163f45de89159db110462d340dc736acf

Please try to get clarification on whether the shared library is
considered to be public (usable by external source packages) or private
(incorrect to use outside the cinnamon-screensaver source package).
It seems like it should be one or the other of those, and I can't give
concrete recommendations without knowing which one.

>From the dependencies I can see in Debian, my best guess would be that
it's probably private, because there is no -dev package that third-party
users of the library could use to link to it, and there is nothing that
Build-Depends on any component of it either?

If it's private, then the packaging could become even simpler
than upstream's, by moving the library and typelib into private
directories and merging everything from libcscreensaver0_*.deb and
gir1.2-cscreensaver-1.0_*.deb into cinnamon-screensaver_*.deb.

Is it acceptable to remove it in Debian packages too or would it be an
unacceptable worsening?

I cannot answer this question, because I don't know whether other packages
in Debian require this GIR XML file.

Perhaps remove it and see whether the rest of Cinnamon still compiles
and works as intended?

     smcv

Thanks for your reply and details, upstream will move the library from shared to private as only used internally: https://github.com/linuxmint/cinnamon-screensaver/pull/456

I started prepared it for debian experimental (https://salsa.debian.org/cinnamon-team/cinnamon-screensaver/-/tree/experimental), I also removed gir file as seems not used.

Is correct and good the actual packaging (in experimental branch) in your opinion?

OpenPGP_signature.asc
Description: OpenPGP digital signature