Arif, Doing reviews and watching the football. Reviews being less stressful - Come on England. :-)
Preamble...
Thank you for taking the time to create/adopt this package and your
contribution to the Debian project.
The review below is for assistance. This review is offered to help
package submitters to Debian mentors inorder to improve their packages
prior to possible sponsorship into Debian. There is no obligation on behalf
of the submitter to make any alterations based upon information provided
in the review.
Review...
1. Build[1]: Good
2. Lintian[2]: Issue - Non blocker at this time
W: sosreport: bad-whatis-entry [usr/share/man/man1/sos-clean.1.gz]
N:
N: A manual page should start with a NAME section, which lists the program
N: name and a brief description. The NAME section is used to generate a
N: database that can be queried by commands like apropos and whatis. You
are
N: seeing this tag because lexgrog was unable to parse the NAME section.
N:
N: Manual pages for multiple programs, functions, or files should list each
N: separated by a comma and a space, followed by \- and a common
description.
N:
N: Listed items may not contain any spaces. A manual page for a two-level
N: command such as fs listacl must look like fs_listacl so the list is read
N: correctly.
N:
N: Please refer to the lexgrog(1) manual page, the groff_man(7) manual
page,
N: and the groff_mdoc(7) manual page for details.
N:
N: Visibility: warning
N: Show-Always: no
N: Check: documentation/manual
N: Renamed from: manpage-has-bad-whatis-entry
N:
N:
W: sosreport: bad-whatis-entry [usr/share/man/man1/sos-collect.1.gz]
N:
W: sosreport: bad-whatis-entry [usr/share/man/man1/sos-collector.1.gz]
N:
W: sosreport: bad-whatis-entry [usr/share/man/man1/sos-help.1.gz]
N:
W: sosreport: bad-whatis-entry [usr/share/man/man1/sos-mask.1.gz]
N:
W: sosreport: bad-whatis-entry [usr/share/man/man1/sos-report.1.gz]
N:
W: sosreport: bad-whatis-entry [usr/share/man/man1/sosreport.1.gz]
N:
W: sosreport: debian-changelog-has-wrong-day-of-week 2024-07-14 was a Sunday
[usr/share/doc/sosreport/changelog.Debian.gz:1]
N:
N: The date in the changelog entry is not consistent with the actual day of
N: that week. Either the date is wrong or the day of week is wrong.
N:
N: To avoid problems like this, consider using a tool like dch(1) or
date(1)
N: to generate the date. Example:
N:
N: $ date -R -ud '2013-11-05 23:59:59'
N: Tue, 05 Nov 2013 23:59:59 +0000
N:
N: Visibility: warning
N: Show-Always: no
N: Check: debian/changelog
N: Renamed from: debian-changelog-has-wrong-weekday
N:
N:
W: sosreport source: newer-standards-version 4.7.0 (current is 4.6.2)
N:
N: The source package refers to a Standards-Version which is newer than the
N: highest one Lintian is programmed to check.
N:
N: If the source package is correct, please upgrade Lintian to the newest
N: version.
N:
N: Visibility: warning
N: Show-Always: no
N: Check: fields/standards-version
N:
N:
W: sosreport: spelling-error-in-changelog unecessary unnecessary
[usr/share/doc/sosreport/changelog.Debian.gz]
N:
N: Lintian found a spelling error in the latest entry of the Debian
N: changelog. Lintian has a list of common misspellings that it looks for.
It
N: does not have a dictionary like a spelling checker does.
N:
N: When writing a changelog entry for a spelling fix that includes the
N: misspelling, ensure the word "spelling" is on the same line as the
N: misspelled word to avoid triggering this warning.
N:
N: Visibility: warning
N: Show-Always: no
N: Check: debian/changelog
N:
N:
W: sosreport: wrong-manual-section 1 != CLEAN [usr/share/man/man1/sos-
clean.1.gz:1]
N:
N: A manual page usually should contain a .TH header, specifying the
section.
N: The section in this manual page doesn't match with the section in the
N: filename.
N:
N: Please refer to the groff_man(7) manual page and the man(1) manual page
N: for details.
N:
N: Visibility: warning
N: Show-Always: no
N: Check: documentation/manual
N: Renamed from: manpage-section-mismatch
N:
N:
W: sosreport: wrong-manual-section 1 != CLEAN [usr/share/man/man1/sos-
mask.1.gz:1]
N:
W: sosreport: wrong-manual-section 1 != COLLECT [usr/share/man/man1/sos-
collect.1.gz:1]
N:
W: sosreport: wrong-manual-section 1 != COLLECT [usr/share/man/man1/sos-
collector.1.gz:1]
N:
W: sosreport: wrong-manual-section 1 != HELP [usr/share/man/man1/sos-
help.1.gz:1]
N:
W: sosreport: wrong-manual-section 1 != REPORT [usr/share/man/man1/sos-
report.1.gz:1]
N:
W: sosreport: wrong-manual-section 1 != REPORT
[usr/share/man/man1/sosreport.1.gz:1]
N:
I: sosreport: acute-accent-in-manual-page [usr/share/man/man1/sos-
report.1.gz:313]
N:
N: This manual page uses the \' groff sequence. Usually, the intent is to
N: generate an apostrophe, but that sequence actually renders as an acute
N: accent.
N:
N: For an apostrophe or a single closing quote, use plain '. For single
N: opening quote, i.e. a straight downward line ' like the one used in
shell
N: commands, use '\(aq'.
N:
N: In case this tag was emitted for the second half of a '\\' sequence,
this
N: is indeed no acute accent, but still wrong: A literal backslash should
be
N: written \e in the groff format, i.e. a '\\' sequence needs to be changed
N: to '\e' which also won't trigger this tag.
N:
N: Please refer to Bug#554897, Bug#507673, and Bug#966803 for details.
N:
N: Visibility: info
N: Show-Always: no
N: Check: documentation/manual
N: Renamed from: acute-accent-in-manpage
N:
N:
I: sosreport: acute-accent-in-manual-page
[usr/share/man/man1/sosreport.1.gz:313]
These issues are to be addressed upstream, thus future uploads to Debian.
3. Licenses (lrc[3]): Good
4. Watch file (uscan --force-download): Issue - Non blocker at this time
philwyett@ks-windu:~/Development/builder/debian/mentoring/sosreport-4.7.2$
uscan --force-download
Successfully renamed ../sos-4.7.2.tar.gz to ../sosreport_4.7.2.orig.tar.gz.
uupdate: You can not execute this from ../sosreport-4.7.2/.
uscan: error: uupdate -f --upstream-version 4.7.2 subprocess returned exit
status 1
5. Build Twice (sudo pbuilder build --twice <package>.dsc): Good
6. Reproducible builds (reporotest)[3]: Good
7. Install (No previous installs): Good
8. Upgrade (Over previous installs if any): Good
Summary...
As discussed with new maintainer (Arif), issues will be resolved as part of
updates and future maintenance.
I believe sosreport is ready for sponsorship/upload. Could a Debian Developer
(DD) with available free time, please review this package and upload if you
feel it is ready.
Regards
Phil
[1] Using:
* pbuilder - https://wiki.ubuntu.com/PbuilderHowto.
* https://wiki.debian.org/PbuilderTricks
and
* sbuild - https://wiki.debian.org/sbuild.
[2] Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc,
*.changes, *.buildinfo). Each can throw up different, so be thorough.
[3] 'lrc' from 'licenserecon' is located in Debian testing and newer.
[4] https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method
--
"I play the game for the game’s own sake"
Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans
--
Internet Relay Chat (IRC): kathenas
Website: https://kathenas.org
Instagram: https://instagram.com/kathenasorg/
Buy Me A Coffee: https://buymeacoffee.com/kathenasorg
--
signature.asc
Description: This is a digitally signed message part
