Arif, Preamble...
Thank you for taking the time to create this package and your contribution to the Debian project. The below review is for assistance. It is offered to help submitters of packages to Debian mentors improve their packages prior to possible sponsorship into Debian. There is no obligation on behalf of the submitter to make any alterations based upon information provided in the review. Review... 1. Build[1]: Good 2. Lintian[2]: Issue W: sosreport: bad-whatis-entry [usr/share/man/man1/sos-clean.1.gz] N: N: A manual page should start with a NAME section, which lists the program N: name and a brief description. The NAME section is used to generate a N: database that can be queried by commands like apropos and whatis. You are N: seeing this tag because lexgrog was unable to parse the NAME section. N: N: Manual pages for multiple programs, functions, or files should list each N: separated by a comma and a space, followed by \- and a common description. N: N: Listed items may not contain any spaces. A manual page for a two-level N: command such as fs listacl must look like fs_listacl so the list is read N: correctly. N: N: Please refer to the lexgrog(1) manual page, the groff_man(7) manual page, N: and the groff_mdoc(7) manual page for details. N: N: Visibility: warning N: Show-Always: no N: Check: documentation/manual N: Renamed from: manpage-has-bad-whatis-entry N: N: W: sosreport: bad-whatis-entry [usr/share/man/man1/sos-collect.1.gz] N: W: sosreport: bad-whatis-entry [usr/share/man/man1/sos-collector.1.gz] N: W: sosreport: bad-whatis-entry [usr/share/man/man1/sos-help.1.gz] N: W: sosreport: bad-whatis-entry [usr/share/man/man1/sos-mask.1.gz] N: W: sosreport: bad-whatis-entry [usr/share/man/man1/sos-report.1.gz] N: W: sosreport: bad-whatis-entry [usr/share/man/man1/sosreport.1.gz] W: sosreport: spelling-error-in-changelog unecessary unnecessary [usr/share/doc/sosreport/changelog.Debian.gz] N: N: Lintian found a spelling error in the latest entry of the Debian N: changelog. Lintian has a list of common misspellings that it looks for. It N: does not have a dictionary like a spelling checker does. N: N: When writing a changelog entry for a spelling fix that includes the N: misspelling, ensure the word "spelling" is on the same line as the N: misspelled word to avoid triggering this warning. N: N: Visibility: warning N: Show-Always: no N: Check: debian/changelog W: sosreport: wrong-manual-section 1 != CLEAN [usr/share/man/man1/sos- clean.1.gz:1] N: N: A manual page usually should contain a .TH header, specifying the section. N: The section in this manual page doesn't match with the section in the N: filename. N: N: Please refer to the groff_man(7) manual page and the man(1) manual page N: for details. N: N: Visibility: warning N: Show-Always: no N: Check: documentation/manual N: Renamed from: manpage-section-mismatch W: sosreport: wrong-manual-section 1 != CLEAN [usr/share/man/man1/sos- mask.1.gz:1] N: W: sosreport: wrong-manual-section 1 != COLLECT [usr/share/man/man1/sos- collect.1.gz:1] N: W: sosreport: wrong-manual-section 1 != COLLECT [usr/share/man/man1/sos- collector.1.gz:1] N: W: sosreport: wrong-manual-section 1 != HELP [usr/share/man/man1/sos- help.1.gz:1] N: W: sosreport: wrong-manual-section 1 != REPORT [usr/share/man/man1/sos- report.1.gz:1] N: W: sosreport: wrong-manual-section 1 != REPORT [usr/share/man/man1/sosreport.1.gz:1] I: sosreport source: override_dh_auto_test-does-not-check-DEB_BUILD_OPTIONS [debian/rules:14] N: N: The debian/rules file for this package has an override_dh_auto_test target N: that does not appear to check DEB_BUILD_OPTIONS against nocheck. N: N: As this check is not automatically performed by debhelper(1), the N: specified testsuite is run regardless of another maintainer using the N: nocheck build option. N: N: Please add a check such as: N: N: override_dh_auto_test: N: ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS))) N: ./run-upstream-testsuite N: endif N: N: Lintian will ignore comments and other lines such as: N: N: # Disabled N: : Disabled N: echo "Disabled" N: mkdir foo/ N: ENV=var dh_auto_test -- ARG=value N: N: This check is not required in Debhelper compat level 13 or greater (see N: Bug#568897). N: N: Please refer to debian/rules and DEB_BUILD_OPTIONS (Section 4.9.1) in the N: Debian Policy Manual and N: https://wiki.debian.org/BuildProfileSpec#Registered_profile_names for N: details. N: N: Visibility: info N: Show-Always: no N: Check: debian/rules I: sosreport: typo-in-manual-page immediatelly immediately [usr/share/man/man1/sos-report.1.gz:382] N: N: Lintian found a spelling error in a manual page. Lintian has a list of N: common misspellings that it looks for. It does not have a dictionary like N: a spelling checker does. N: N: If the string containing the spelling error is translated with the help of N: gettext (with the help of po4a, for example) or a similar tool, please fix N: the error in the translations as well as the English text to avoid making N: the translations fuzzy. With gettext, for example, this means you should N: also fix the spelling mistake in the corresponding msgids in the *.po N: files. N: N: Visibility: info N: Show-Always: no N: Check: documentation/manual N: Renamed from: spelling-error-in-manpage N: N: I: sosreport: typo-in-manual-page immediatelly immediately [usr/share/man/man1/sosreport.1.gz:382] 3. Licenses (lrc): Good Note: 'lrc' will flag as GPL-2 on many files, but this is because the file header(s) states: # This copyrighted material is made available to anyone wishing to use, # modify, copy, or redistribute it subject to the terms and conditions of # version 2 of the GNU General Public License. Changing to "version 2 or later" fixes the issue. Something I would see if it can be fixed upstream. Additional: Please review copyright year. 4. Watch file (uscan --force-download): Issue Not a blocker, but errors are always bad. philwyett@ks-windu:~/Development/builder/debian/mentoring/sosreport-4.7.2$ uscan --force-download Successfully renamed ../sos-4.7.2.tar.gz to ../sosreport_4.7.2.orig.tar.gz. uupdate: You can not execute this from ../sosreport-4.7.2/. uscan: error: uupdate -f --upstream-version 4.7.2 subprocess returned exit status 1 5. Build Twice (sudo pbuilder build --twice <package>.dsc): Good 6. Reproducible builds (reporotest)[3]: Good 7. Install (No previous installs): Good 8. Upgrade (Over previous installs if any): Good Summary... This package has been uploaded while a review was being done. Could the maintainer look at the review and address any relevant issues please. [1] Using pbuilder and sbuild. [2] lintian -v -i -I -E --pedantic --profile debian (*.dsc, *.changes, *.buildinfo). Each can throw up different, so be thorough. [3] https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method Regards Phil -- "I play the game for the game’s own sake" Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans -- Internet Relay Chat (IRC): kathenas Website: https://kathenas.org Instagram: https://instagram.com/kathenasorg/ Buy Me A Coffee: https://buymeacoffee.com/kathenasorg --
signature.asc
Description: This is a digitally signed message part
