Hi,
On 07/07/2024 05:37, Phil Wyett wrote:
Control: tags -1 + moreinfo
Morning Alexis,
Preamble...
Thanks for taking time to create this package and your contribution to Debian.
Thanks for your review :)
A. Package 'streamlink' in 'debian/control' should not be forcing the install
of any particular
video player on the user.
Recommends: vlc | mpv | mplayer
Streamlink is primarily used to download a live stream to a video player,
and only some of them are supported (not all possible video players) [1].
This is why they were put as Recommends.
But I agree that streamlink can work fine without any players
and an user wanting to use it with a player will probably already have
it.
If not, streamlink will print an error about it like this:
```
error: The default player (VLC) does not seem to be installed. You must specify
the path to a player executable with --player, a file path to save the stream
with --output, or pipe the stream to another program with --stdout.
```
So I will move these Recommends to Suggests instead.
[1] https://streamlink.github.io/players.html#player-compatibility
--
Alexis Murzeau
PGP: B7E6 0EBB 9293 7B06 BDBC 2787 E7BD 1904 F480 937F |
