Hi Alexandre, Preamble...
Thanks for taking time to create this package and your contribution to Debian. The below review is for assistance. It is offered to help submitters of packages to Debian mentors improve their packages prior to possible sponsorship into Debian. There is no obligation on behalf of the subitter to make any alterations based upon information provided in the review. Review... 1. Build: Good 2. Lintian: Issue I: adminer source: composer-package-without-pkg-php-tools-builddep [composer.json] N: N: The package contains a composer.json file but doesn't build-depend on N: pkg-php-tools. N: N: pkg-php-tools is the recommended tool for building PHP Composer packages. N: For more information, install it and read the included README.Composer. N: N: Visibility: info N: Show-Always: no N: Check: languages/php/pear I: adminer: package-contains-empty-directory [usr/share/adminer/designs/hydra/] N: N: This package installs an empty directory. This might be intentional but N: it's normally a mistake. If it is intentional, add a Lintian override. N: N: If a package ships with or installs empty directories, you can remove them N: in debian/rules by calling: N: N: $ find path/to/base/dir -type d -empty -delete N: N: Visibility: info N: Show-Always: no N: Check: files/empty-directories N: N: I: adminer: package-contains-empty-directory [usr/share/adminer/designs/pepa-linha-dark/] 3. Licenses: Issue philwyett@ks-windu:~/Development/builder/debian/mentoring/adminer-4.8.1$ lrc en: Versions: recon 1.11 check 3.3.9-1 Parsing Source Tree .... Reading copyright .... Running licensecheck .... d/copyright | licensecheck MIT | Expat designs/price/adminer.css Apache-2.0 | Expat designs/rmsoft/adminer.css Apache-2.0 | Expat designs/rmsoft_blue/adminer.css Debian copyright year should also be updated with any changes. 4. Build Twice (sudo pbuilder build --twice <package>.dsc): Good 5. Reproducible builds (reporotest)[1]: Good 6. Install (No previous installs): Good 7. Upgrade (Over previous installs if any): Good Summary... I believe adminer is ready for sponsorship/upload. Could a Debian Developer (DD) with available free time, please review this package and upload if you feel it is ready. I would hope the issues raised will be given consideration post this CVE upload. [1] https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method Regards Phil -- Internet Relay Chat (IRC): kathenas Website: https://kathenas.org Instagram: https://instagram.com/kathenasorg/ Buy Me A Coffee: https://buymeacoffee.com/kathenasorg
signature.asc
Description: This is a digitally signed message part
