Control: tags -1 + moreinfo

Hi Jorg,

Preamble...

Thanks for taking time to create this package and your contribution to Debian.

The below review is for assistance. It is offered to help submitters of
packages to Debian mentors improve their packages prior to possible
sponsorship into Debian. There is no obligation on behalf of the subitter to
make any alterations based upon information provided in the review.

Review...

1. Build: Good

2. Lintian: Issue

I: xtrkcad-common: image-file-has-conflicting-name (is JPEG) 
[usr/share/doc/xtrkcad-
common/html/png.d/mzoomscale.png]
N: 
N:   An image file in this package has a name that is usually associated with
N:   another image format.
N: 
N:   Please refer to Bug#717818 for details.
N: 
N:   Visibility: info
N:   Show-Always: no
N:   Check: images/filenames

Needs to be rectified immediately in my opinion.

I: xtrkcad: spelling-error-in-binary Perferences Preferences [usr/bin/xtrkcad]
N: 
N:   Lintian found a spelling error in the given binary. Lintian has a list of
N:   common misspellings that it looks for. It does not have a dictionary like
N:   a spelling checker does.
N:   
N:   If the string containing the spelling error is translated with the help of
N:   gettext or a similar tool, please fix the error in the translations as
N:   well as the English text to avoid making the translations fuzzy. With
N:   gettext, for example, this means you should also fix the spelling mistake
N:   in the corresponding msgids in the *.po files.
N:   
N:   You can often find the word in the source code by running:
N:   
N:    grep -rw <word> <source-tree>
N:   
N:   This tag may produce false positives for words that contain non-ASCII
N:   characters due to limitations in strings.
N: 
N:   Visibility: info
N:   Show-Always: no
N:   Check: binaries/spelling
N: 
N:
I: xtrkcad: spelling-error-in-binary guage gauge [usr/bin/xtrkcad]
N:
I: xtrkcad: spelling-error-in-binary hilighted highlighted [usr/bin/xtrkcad]
N:
I: xtrkcad: spelling-error-in-binary seperation separation [usr/bin/xtrkcad]
N:
I: xtrkcad: spelling-error-in-binary wTH with [usr/bin/xtrkcad

For upstream to rectify if possible. Patched if not.

I: xtrkcad-common: unused-override source-is-missing 
[app/doc/xtrkcad-manual-5.3.0.html]
[usr/share/lintian/overrides/xtrkcad-common:2]
N: 
N:   Your package specifies the named override but there were no tags that
N:   could have been silenced by it.
N:   
N:   Maybe you fixed an underlying condition but forgot to remove the override.
N:   It is also possible that the Lintian maintainers fixed a false positive.
N:   
N:   If the override is now unused, please remove it.
N:   
N:   This tag is similar to mismatched-override except there a tag could have
N:   been silenced if the context had matched.
N:   
N:   Sometimes, overrides end up not being used because a tag appears only on
N:   some architectures. In that case, overrides can be equipped with an
N:   architecture qualifier.
N: 
N:   Please refer to Architecture specific overrides (Section 2.4.3) in the
N:   Lintian User's Manual for details.
N: 
N:   Visibility: info
N:   Show-Always: yes
N:   Check: lintian

3. Licenses: Good

4. Build Twice (sudo pbuilder build --twice <package>.dsc): Good

5. Reproducible builds (reporotest)[1]: Good

6. Install (No previous installs): Not performed due to (2. Lintian).

7. Upgrade (Over previous installs if any): Not performed due to (2. Lintian).

Summary...

I believe xtrkcad is not yet ready for sponsorship/upload. Could the 
contributor rectify one of more of the rasied issues. Once updated to your 
satisfaction and a new upload done, please remove the 'moreinfo' on the Request 
For Sponsorship (RFS) bug report.

[1] https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method

Regards

Phil

-- 

Internet Relay Chat (IRC): kathenas

Website: https://kathenas.org

Instagram: https://instagram.com/kathenasorg/

Buy Me A Coffee: https://buymeacoffee.com/kathenasorg

Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to