Hi Bryce,

that hook is not being installed anymore since

commit 5bf93011c0b4c02cd7e6169e8bbba56b87ea14c4
Author: Bernd Zeimetz <be...@bzed.de>
Date:   Fri Jan 19 00:25:09 2018 +0100

    Drop -dkms package.

    Closes: #884656
    Thanks: Christian Ehrhardt


Or did I miss something? Did you find the hook on a recently installed
system?

I've removed the file from the repository.


Bernd

On Wed, 2024-07-03 at 13:28 -0700, Bryce Harrington wrote:
> Hi Maintainers,
> 
> In doing further investigation, I suspect this hook is entirely
> vestigal
> and should be dropped from packaging.
> 
> Neither pcnet32.* nor vmxnet appear to be referenced anywhere else in
> debian/*, and I could not find an obvious way to install things that
> would exercise the conditional.
> 
> In doing some git archaeology[1], I discovered that vmxnet used to be
> installed by a deprecated binary module that was finally dropped from
> the packaging with the changeset to remove the -dkms package[2].
> 
> So I think the file debian/local/vmxnet.hook should have been deleted
> with that, and thus can simply be dropped now.
> 
> 1:
> https://code.launchpad.net/~bryce/ubuntu/+source/open-vm-tools/+git/open-vm-tools/+merge/468120
> 2:
> https://salsa.debian.org/vmware-packaging-team/pkg-open-vm-tools/-/commit/5bf93011c0b4c02cd7e6169e8bbba56b87ea14c4

-- 
 Bernd Zeimetz                            Debian GNU/Linux Developer
 http://bzed.de                                http://www.debian.org
 GPG Fingerprint: ECA1 E3F2 8E11 2432 D485  DD95 EB36 171A 6FF9 435F

Reply via email to