Package: libcgi-application-plugin-authentication-perl
Version: 0.24+~cs0.5-1
Severity: serious
Tags: patch ftbfs
Justification: fails to build from source (but built successfully in the past)
X-Debbugs-Cc: chris.peter...@canonical.com
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu oracular ubuntu-patch
libcgi-application-plugin-authentication-perl's build time tests fail
due to a change in behavior in libcgi-pm-perl with trailing slashes in
URLs. In particular, a test was failing which compared generated output
with a reference output that was generated with an older version of
libcgi-pm-perl. I applied the attached patch to fix the issue Ubuntu and
also forwarded it upstream.
Thanks for considering the patch.
- cpete
diff -Nru
libcgi-application-plugin-authentication-perl-0.24+~cs0.5/debian/patches/login-box-basic.patch
libcgi-application-plugin-authentication-perl-0.24+~cs0.5/debian/patches/login-box-basic.patch
---
libcgi-application-plugin-authentication-perl-0.24+~cs0.5/debian/patches/login-box-basic.patch
1969-12-31 16:00:00.000000000 -0800
+++
libcgi-application-plugin-authentication-perl-0.24+~cs0.5/debian/patches/login-box-basic.patch
2024-06-27 16:02:21.000000000 -0700
@@ -0,0 +1,23 @@
+Description: Update test for CGI.pm >=4.66
+ CGI.pm made changes to "restore the trailing slash in ->url" in 4.66[1],
+ which causes a test failure in one of the tests comparing output with
+ a reference generated by a previous version of CGI.pm. This patch
+ updates the reference file for compatibility with CGI.pm >= 4.66.
+
+ [1]
https://github.com/leejo/CGI.pm/commit/a5485b5f3b2b1cc85761b6781ff6660b4f377498
+Author: Chris Peterson <chris.peter...@canonical.com>
+Forwarded:
https://github.com/MicroTechnology-Services/cgi-application-plugin-authentication/pull/2
+Bug-Ubuntu:
https://bugs.launchpad.net/ubuntu/+source/libcgi-application-plugin-authentication-perl/+bug/2071369
+Last-Update: 2024-06-27
+---
+This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
+--- a/t/out/basic_login_box
++++ b/t/out/basic_login_box
+@@ -28,6 +28,6 @@
+ </div>
+ </div>
+ </div>
+- <input type="hidden" name="destination" value="http://localhost"; />
++ <input type="hidden" name="destination" value="http://localhost/"; />
+ <input type="hidden" name="rm" value="one" />
+ </form>
diff -Nru
libcgi-application-plugin-authentication-perl-0.24+~cs0.5/debian/patches/series
libcgi-application-plugin-authentication-perl-0.24+~cs0.5/debian/patches/series
---
libcgi-application-plugin-authentication-perl-0.24+~cs0.5/debian/patches/series
1969-12-31 16:00:00.000000000 -0800
+++
libcgi-application-plugin-authentication-perl-0.24+~cs0.5/debian/patches/series
2024-06-27 11:32:51.000000000 -0700
@@ -0,0 +1 @@
+login-box-basic.patch
