Hi, On 20/06/2024 23:29, Phil Wyett wrote:
Control: tags -1 + moreinfoHi Alexis, Thanks for taking time to create this package and your contribution to Debian. I see you have submitted this Request For Sponsorship (RFS) but not toggled 'Needs a sponsor' on the mentors site. I will offer a review that may assist you in your good work for the Debian project. Review... 1. Build: OK 2. Lintian: INFORMATION I: streamlink source: built-using-field-on-arch-all-package (in section for python3-streamlink-doc) Built-Using ${sphinxdoc:Built-Using} [debian/control:72] N: N: The stanza for an installation package in debian/control declares a N: Built-Using field even though the package is declared as Architecture: N: all. That is incorrect. N: N: The Built-Using field is only used architecture-specific packages. Please N: remove the Built-Using field from the indicated location. N: N: Visibility: info N: Show-Always: no N: Check: debian/control/field/built-using N: Please could this be looked at for a future release/upload. 3. Licenses check: ISSUES philwyett@ks-windu:~/Development/builder/debian/mentoring/streamlink-6.8.1$ lrc en: Versions: recon 1.10.1 check 3.3.9-1 Parsing Source Tree .... Reading copyright .... Running licensecheck .... d/copyright | licensecheck Apache-2 | Apache-2.0 src/streamlink/packages/requests_file.py Minor and an easy fix. 4. Build Twice (sudo pbuilder build --twice <package>.dsc): OK 5. Install (No previous installs): OK 6. Upgrade (Over previous installs if any): OK Additional... A. 'debian/control' Please update to the latest 'Standards-Version' which is 4.7.0. https://www.debian.org/doc/debian-policy/ Summary... Please consider addressing the issues raised where applicable and remove the 'moreinfo' tag when doing next/fixed upload. Regards Phil
Thanks for your review. As this version is already uploaded, I've done the fixes for the next upstream version: - Fix the lintian issue about Built-Using (I kept it before as it was not clear to me whether sphinx-generated docs should use it or not). - Fix license short name: Apache-2 => Apache-2.0. - Bump standard version to 4.7.0 (no change required). See also: https://salsa.debian.org/amurzeau/streamlink/ -- Alexis Murzeau PGP: B7E6 0EBB 9293 7B06 BDBC 2787 E7BD 1904 F480 937F |
