Hi,

thank you for your patch!

Quoting Colin Watson (2024-06-17 12:20:44)
> --- /usr/bin/mmdebstrap-autopkgtest-build-qemu  2024-05-14 06:39:00.000000000 
> +0100
> +++ mmdebstrap-autopkgtest-build-qemu   2024-06-17 11:17:34.619003852 +0100
> @@ -235,26 +235,31 @@
>                 EFIIMG=bootx64.efi
>                 QEMUARCH=x86_64
>                 VMFPKG=ovmf
> +               LINUXIMAGE=linux-image-amd64
>         ;;
>         arm64)
>                 EFIIMG=bootaa64.efi
>                 QEMUARCH=aarch64
>                 VMFPKG=qemu-efi-aarch64
> +               LINUXIMAGE=linux-image-arm64
>         ;;
>         armhf)
>                 EFIIMG=bootarm.efi
>                 QEMUARCH=arm
>                 VMFPKG=qemu-efi-arm
> +               LINUXIMAGE=linux-image-armmp
>         ;;
>         i386)
>                 EFIIMG=bootia32.efi
>                 QEMUARCH=i386
>                 VMFPKG=ovmf-ia32
> +               LINUXIMAGE=linux-image-rt-686-pae

Why with PREEMPT_RT and not just linux-image-686-pae?

>         ;;
>         riscv64)
>                 EFIIMG=bootriscv64.efi
>                 QEMUARCH=riscv64
>                 VMFPKG=
> +               LINUXIMAGE=linux-image-riscv64
>         ;;
>         *)
>                 die "unsupported architecture: $ARCHITECTURE"
> @@ -344,7 +349,7 @@
>         set -- "$@" --hook-dir=/usr/share/mmdebstrap/hooks/jessie-or-older
>  
>  set -- "$@" \
> -       "--include=init,linux-image-$ARCHITECTURE,python3" \
> +       "--include=init,$LINUXIMAGE,python3" \
>         '--customize-hook=echo host >"$1/etc/hostname"' \
>         '--customize-hook=echo 127.0.0.1 localhost host >"$1/etc/hosts"' \
>         '--customize-hook=passwd --root "$1" --delete root' \

It seems to me that the kernel selection should follow what debvm does:

https://sources.debian.org/src/debvm/0.3/share/customize-kernel.sh/#L20

Thanks!

cheers, josch

Attachment: signature.asc
Description: signature

Reply via email to