Hi, Thanks for your quick reply.
On Thu, Jun 13, 2024 at 12:20:07PM -0400, Andres Salomon wrote:
On 6/13/24 11:06, Bo YU wrote:Version: 125.0.6422.141-1 Tags: patch
...
Sorry if I am disorder to reply the thread. Based on 125, now chromium is worked on riscv64 real hardware again, in other words, it works on Unmatched board with amd graphic card. For upstream, there are two mainly part was left still: ffmpeg and sandbox. I am impressed by their response for this: they have to get approval from chromium project leaders. I am optimistic that they willIs there an upstream bug report for this? For sandbox in particular, that patch is a lot and needs to go upstream. I would like to be building against the ffmpeg debian package, which would make the ffmpeg patch go away.
That is great if we are building against ffmpeg package instread of ffmpeg bundled. This will reduce maintenance burden on ppc64 or rv64 also. anyway, the upstream bug was opened already: https://chromium-review.googlesource.com/c/chromium/third_party/ffmpeg/+/5054185 In fact, I noticed we have tested dav1d[0] package in the past to rebase the riscv64 patchset. For sandbox, we do not have other choice than upstream support it: https://chromium-review.googlesource.com/c/chromium/src/+/4935120 Many distributions on riscv64 use this patch.
eventually support riscv64 given the involve of riscv's software and hardware ecosystem. > On debian side, we have testing suite for riscv64 now so we can review it as a decent port status. As a riscv porter, I can maintain the patchset to support riscv64 for a long time. In the past few months, I have been providing deb package[0] for some users. So could we evaluate this patch again? please let me know if any issues.There's some random unnecessary stuff in this patchset, like ppc64le patches. Also, 0008-HACK-devtools-remove-terser.patch removes terser but doesn't explain _why_, and that patch affects all architectures. The rest of the patches (other than sandbox and ffmpeg) look reasonable.
ah, sorry, it seems I forget to clear these unused patches. My attention is focused on to update ffmpeg. see series[1] ``` --- chromium-125.0.6422.141/debian/patches/series 2024-05-31 10:11:26.000000000 +0800 +++ chromium-125.0.6422.141/debian/patches/series 2024-05-21 18:21:02.000000000 +0800 @@ -141,3 +141,10 @@ # These patches enable full POWER ISA 3.0 (POWER9) acceleration when applied # They will not work on POWER8 (ISA 2.07) or below #ppc64le/core/baseline-isa-3-0.patch +riscv64/0001-cpuinfo.patch +riscv64/0003-cpuinfo-drop-hwprobe.patch +riscv64/0004-ffmpeg-generated-config.patch +riscv64/0005-add-riscv64-support-ffmpeg.patch +riscv64/0006-fix-rustc-build.patch +riscv64/0007-fix-rust-ld.patch +riscv64/0010-sandbox.patch ``` Okay, let me refresh these patches again.
[0]: https://salsa.debian.org/chromium-team/chromium/-/commit/0ef9a36c98ec9b5470c281fff7a63dfc713a875e [1]: https://bugs.debian.org/cgi-bin/bugreport.cgi?att=1;bug=1051998;filename=chromium_support_riscv64.debdiff;msg=107 -- Regards, -- Bo YU
signature.asc
Description: PGP signature
