Package: nodejs
Version: 20.14.0+dfsg-1
Severity: serious
Tags: patch

OpenSSL 3.2.2 introduced an error code a behaviour Node was testing and
now "test/parallel/test-http2-https-fallback.js" is unhappy. The OpenSSL
change is was introduced in https://github.com/openssl/openssl/pull/24338.

I don't know if node relies on that error outside of the testsuite. The
patch attached swaps the error code and the test passes. OpenSSL 3.2.2
is currently in unstable.

Sebastian
From: Sebastian Andrzej Siewior <sebast...@breakpoint.cc>
Date: Tue, 11 Jun 2024 19:30:13 +0000
Subject: [PATCH] tests: Check for real error code

OpenSSL since 3.2.2 got an actual error code for the behaviour node was
testing. It was introduced by https://github.com/nodejs/node/pull/53384.

Signed-off-by: Sebastian Andrzej Siewior <sebast...@breakpoint.cc>
---
 test/parallel/test-http2-https-fallback.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/parallel/test-http2-https-fallback.js b/test/parallel/test-http2-https-fallback.js
index 8e0612375f48..d44e49ab021c 100644
--- a/test/parallel/test-http2-https-fallback.js
+++ b/test/parallel/test-http2-https-fallback.js
@@ -151,7 +151,7 @@ function onSession(session, next) {
       // Incompatible ALPN TLS client
       tls(Object.assign({ port, ALPNProtocols: ['fake'] }, clientOptions))
         .on('error', common.mustCall((err) => {
-          strictEqual(err.code, 'ECONNRESET');
+          strictEqual(err.code, 'ERR_SSL_TLSV1_ALERT_NO_APPLICATION_PROTOCOL');
           cleanup();
           testNoALPN();
         }));

Reply via email to