Hi, On Mon, May 20, 2024 at 04:16:49PM -0400, Daniel Kahn Gillmor wrote: > On Sun 2024-05-19 20:43:58 +0200, Guido Günther wrote: > > But you'd break that when filtering out files? I think what keeps me > > confused: the tarball uploaded to Debian is the filtered one and hence > > has a different checksum, no? > > hm, i don't think so, because we use > import-orig.filter-pristine-tar=False. This lets me preserve both the
Ah...now I get it. You filter the branch but let pristine-tar take care of restoring the original tarball. [..snip..] > > Another reason to not parse debian/clean verbatim is that we'd also need > > to support dh's substitution variables and would forever need to follow > > what dh does (and we might even need to pay attention to the dh compat > > level of the package) as otherwise things would break on people. > > you've convinced me that running the clean target is better than trying > to parse debian/clean :) Great! Let's try that path then. > > >> whether the packaging used debhelper or not. Does that seem like a > >> plausible way to operate gbp import-orig? > > > > That would be an approach. Implementation wise the "tricky" bit is > > that you don't have debian/ on the upstream branch you want to filter so > > dh_clean or `debian/rules clean` won't work as is . So we'd need to > > overlay that (which is certainly doable, just wanted to point it out). > > ah, yes, i see the complication here. > > > So that's a lot of effort for s.th. that can already be done via either > > gbp.conf or FilesExcluded. I'm not against it, just looking at the pros > > and cons. > > right, i see tradeoff you're describing, and if you decide this is too > much complication for gbp, i'm willing to just keep the two lists > (debian/clean and debian/gbp.conf's import-orig.filter) in sync more or > less manually. I'm fine with the complication. Just wanted to point out possible implementation pitfalls. Just to be sure: It's unlikely that I'll be able to look at an implementation myself near term. > Thanks for thinking this all through with me here, Guido! Thanks for explaining your workflow! -- Guido
