Xiyue Deng <manp...@gmail.com> writes: > Xiyue Deng <manp...@gmail.com> writes: > >> Xiyue Deng <manp...@gmail.com> writes: >> >>> Sean Whitton <spwhit...@spwhitton.name> writes: >>> >>>> Hello, >>>> >>>> On Wed 27 Mar 2024 at 11:40pm -07, Xiyue Deng wrote: >>>> >>>>> Sean Whitton <spwhit...@spwhitton.name> writes: >>>>> >>>>>> Hello, >>>>>> >>>>>> Rob, can you review the implementation in d/rules for Xiyue's patch to >>>>>> this bug, please? I'm not sure it's the straightforward way to do it. >>>>>> >>>>>> Xiyue, I think it would make sense to use emacs-common (<< 1:29.3+2-2), >>>>>> for the relationships. >>>>> >>>>> Ah indeed, I should update the versions after the Emacs 29.3 upload, >>>>> though I think you meant "1:29.3+1-2". Also, as we are just moving >>>>> files from emacs-common to emacs-pgtk, breaks/replaces is only needed >>>>> from emacs-pgtk to emacs-common but no the other way around, so I >>>>> dropped the breaks on emacs-pgtk from emacs-common. >>>>> >>>>> I have updated the patch accordingly and attached here. PTAL. >>>> >>>> Thanks. >>>> >>>>> (BTW, I'm always curious about the "+1" part of the version number. I >>>>> would expect something like "+dfsg" or "+ds" as we are dropping some >>>>> of the non-DFSG conformant files, but why "+1"? :) >>>> >>>> It's just in case the DFSG split is done incorrectly and another attempt >>>> is required -- given how complex it is. >>> >>> Ack, totally understandable. >>> >>> With the release of Emacs 1:29.3+1-2, I have rebased the patch onto it >>> and bumped the breaks/replaces version. PTAL. >> >> Rob suggested on IRC to be a bit more conservative by removing the file >> and remove the directories upwards recursively so that we can catch >> future addition to the directories more easily. The patch has been >> adjusted accordingly. PTAL. > > Friendly ping. Rob, do you have any more comments on the current > approach?
Friendly ping 2 :) -- Xiyue Deng
