Hi,

In ubuntu we applied the upstream's fix at
https://github.com/radvd-project/radvd/pull/196. I adapted it to a pair of
patches that I attach here for fixing this FTBFS.

I am sending this for your consideration, and I hope it helps.

Best,

Miriam

-- 
[image: Canonical-20th-anniversary]

Miriam EspaƱa Acebal

Software Engineer II - Ubuntu Public Cloud/Server

Email:

miriam.esp...@canonical.com

Location:

Spain  (GMT+2)

canonical.com

ubuntu.com
Origin: upstream, https://github.com/radvd-project/radvd/commit/e0f5bcd9091a5f7abd423fce9f372c8079849a64
From: Sam James <s...@gentoo.org>
Date: Thu, 17 Nov 2022 22:03:25 +0000
Subject: [PATCH] gram.y: Fix -Wimplicit-function-declaration

Clang 16 makes -Wimplicit-function-declaration an error by default.

For more information, see LWN.net [0] or LLVM's Discourse [1], the Gentoo wiki [2],
or the (new) c-std-porting mailing list [3].

[0] https://lwn.net/Articles/913505/
[1] https://discourse.llvm.org/t/configure-script-breakage-with-the-new-werror-implicit-function-declaration/65213
[2] https://wiki.gentoo.org/wiki/Modern_C_porting
[3] hosted at lists.linux.dev.

Bug-Gentoo: https://bugs.gentoo.org/880823
Bug-Ubuntu: https://bugs.launchpad.net/debian/+source/radvd/+bug/2061370
Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1066224
Forwarded: yes
Signed-off-by: Sam James <s...@gentoo.org>
---
 gram.y | 4 ++++
 1 file changed, 4 insertions(+)

--- a/gram.y
+++ b/gram.y
@@ -20,6 +20,10 @@
 
 #define YYERROR_VERBOSE 1
 
+int yylex (void);
+void yyset_in (FILE * _in_str);
+int yylex_destroy (void);
+
 #if 0 /* no longer necessary? */
 #ifndef HAVE_IN6_ADDR_S6_ADDR
 # ifdef __FreeBSD__
Origin: upstream, https://github.com/radvd-project/radvd/commit/ff7ab0cf445236f30e58531175ba912614fed952
From: Sam James <s...@gentoo.org>
Date: Thu, 17 Nov 2022 22:03:25 +0000
Subject: [PATCH] Makefile.am: drop -Wno-implicit-function-declaration

1. Clang 16 makes -Wimplicit-function-declaration error by default
   (and it's planned that GCC 14 will do the same) so we need to fix
   the real problem. This is papering over it.

2. It's not true that there's nothing we can do about it. Fix in a follow-up
   commit.

Bug-Gentoo: https://bugs.gentoo.org/880823
Bug-Ubuntu: https://bugs.launchpad.net/debian/+source/radvd/+bug/2061370
Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1066224
Forwarded: yes
Signed-off-by: Sam James <s...@gentoo.org>
---
 Makefile.am | 3 ---
 1 file changed, 3 deletions(-)

--- a/Makefile.am
+++ b/Makefile.am
@@ -66,9 +66,6 @@
 scanner.c: gram.h
 gram.h: gram.c
 
-libradvd_parser_a_CFLAGS = \
-	-Wno-implicit-function-declaration
-
 libradvd_parser_a_SOURCES = \
 	gram.h \
 	gram.y \
  • Bug#1066224: Miriam Espana Acebal

Reply via email to