Hi, Extensive discussion between the bug reporter and the Ethereal development team lead to the conclusion that the patch is incorrect and should be dropped.
Thanx, Jaap ---------- Forwarded message ---------- Date: Tue, 25 Apr 2006 12:57:18 +0200 From: Joost Yervante Damad <[EMAIL PROTECTED]> To: Jaap Keuter <[EMAIL PROTECTED]> Cc: Anders Broman <[EMAIL PROTECTED]> Subject: Re: SV: Debian Bug report logs - #316082 Hi Jaap, Anders, this is my suggestion: go with the current implementation. If the need arises for me to use diameter again, I will surely use ethereal again for it, and if it's still not working I'll do a proper investigate. Sorry I could not be of more help. Congrats with the 1.0! Greetings, Joost On Tuesday 25 April 2006 07:57, Jaap Keuter wrote: > Hi Joost, > > We're steadily approaching Ethereal 1.0 (yes, it's freezing in hell :) > so we should get to a conclusion on this before Frederic starts packaging > that release. > > Thanx, > Jaap > > On Sun, 2 Apr 2006, Joost Yervante Damad wrote: > > Hi Jaap, Anders, > > > > sorry, I've been occupied by other things and completely forgot about it > > as the work I needed diameter support for is long finished :) > > > > I'll try and find some time for this this week. > > > > Joost > > > > On Monday 20 March 2006 20:30, Anders Broman wrote: > > > Hi, > > > The "fix" is not correct. Actually it breaks the loading of xml files > > > if I remember correctly. > > > Joost said he'd test his xml files further as he found some problems > > > with them after I showed him how to get better debug info from the > > > diameter dissector. I have also subsequently updated our own files. If > > > there still is a problem it needs a different solution. > > > Brg > > > Anders > > > > > > -----Ursprungligt meddelande----- > > > Fr?n: Jaap Keuter [mailto:[EMAIL PROTECTED] > > > Skickat: den 20 mars 2006 16:29 > > > Till: Joost Yervante Damad > > > Kopia: Anders Broman > > > ?mne: Debian Bug report logs - #316082 > > > > > > Hi Joost, > > > > > > ethereal: fails to correctly add diameter vendors from the dictionary > > > xml files > > > > > > You've discussed this issue with Anders Broman and worked out the way > > > to go forward. Still the Ethereal code base is the same and the bug > > > report is still open. What was the conclusion of your discussion? > > > Should the code be changed or the bugreport, including patch, be > > > dropped? We have to come to some conclusion here in order to > > > synchronize Debian and 'Rest Of World' use of diameter files. > > > > > > Thanx, > > > Jaap -- The planet Andete is famous for it's killer edible poets.
