Hello,

your request and your patch both seem really reasonable to me. I'll add this
in a future release of the package, I promise. But I cannot give any
timeframe for this, since my real life is going really frenetic right now.

Sorry about this, and thanks for this bug repport.
Mt.


On Fri, Jun 02, 2006 at 09:26:54AM +0300, Jari Aalto wrote:
> Package: quilt
> Version: 0.44-6.1
> Severity: minor
> 
> EXAMPLE:
> 
>   $ export QUILT_PATCHES="debian/quilt"
>   .. time passes
>   $ quilt series -v
>   <nothing>
> 
> It took fairly long time to figure out why quilt was not working at
> all. The previous project's QUILT_PATCHES pointed to wrong location.
> 
> SUGGESTION
> 
> Please add a warning that series file does not exist to stdree to
> catch this mistake. The function in question is in 
> 
>   /usr/share/quilt/scripts/patchfns::cat_series
> 
> My proposed changed function is below. (!) used for new lines.
> 
> -----------------------------------------------------------------------
> cat_series()
> {
>       if [ -e $SERIES ]
>       then
>               sed -e '/^$/d' -e '/^#/d' -e 's/^[ '$'\t'']*//' \
>                   -e 's/[ '$'\t''].*//' $SERIES
>       else
> !             if [ "$opt_verbose" ]; then
> !                 echo "series file not found: $SERIES" >&2
> !             fi
>               return 1
>       fi
> }
> 
> 
> 
> -- System Information:
> Debian Release: testing/unstable
>   APT prefers unstable
>   APT policy: (500, 'unstable'), (500, 'stable')
> Architecture: i386 (i686)
> Shell:  /bin/sh linked to /bin/dash
> Kernel: Linux 2.6.16-1-686
> Locale: LANG=C, LC_CTYPE=C (charmap=ISO-8859-1) (ignored: LC_ALL set to en_US)
> 
> Versions of packages quilt depends on:
> ii  bzip2                     1.0.3-2        high-quality block-sorting file 
> co
> ii  diffstat                  1.41-1         produces graph of changes 
> introduc
> ii  gawk                      1:3.1.5.dfsg-4 GNU awk, a pattern scanning and 
> pr
> ii  gettext                   0.14.5-4       GNU Internationalization 
> utilities
> ii  patch                     2.5.9-4        Apply a diff file to an original
> 
> quilt recommends no packages.
> 
> -- no debconf information
> 
> 

-- 
Quelqu'un qui a commis des atrocités mérite la peine de mort. Ainsi, il
retiendra la leçon pour la prochaine fois.
          --- Britney Spears

Attachment: signature.asc
Description: Digital signature

Reply via email to