On 17.03.2024 00:55, Jonas Smedegaard wrote:
Thanks for the proposed patch.
Unfortunately it does not apply to the Debian package.
First: apologies.
I seem to have made a mistake during my dist-upgrade and ended up with the old init-script, which makes my provided "patch" logically totally wrong.

Please provide a patch against the Debian package (not Devuan).
which makes this request unnecessary, because the devuan package is identical to the debian package.

Also, nothing else in the Debian packaging messes with the path
"$dir/collection-root" - that is left for Radicale itself to handle.
Can you please test if adequate to replace the 3 instances of
"$dir/collections" with "$dir" instead?

So the actual needed patch is quite small and more cosmetic, since it works out of the box, just w/o logging. And your suggested adjustment works, too.

Again, apologies for my f***up.

I had a minor problem changing the storage dir.
All works fine with the defaults storage dir (/var/lib/radicale/collections). When changing it to a different location in the config file, I only got it working, if I do not generate the "storage" part from "filesystem_folder = /path/to/storage" beforehand.

Otherwise I get a write permission problem.
--- radicale_orig	2024-03-17 18:39:40.696898778 +0100
+++ radicale	2024-03-17 18:41:25.995228178 +0100
@@ -55,9 +55,9 @@
 			chown $DAEMON_UID:$DAEMON_GID $dir
 			chmod g-w,o-rwx $dir
 			if [ "$CALDIR" = $dir ]; then
-				[ -e $dir/collections ] || mkdir -p $dir/collections
-				chown $DAEMON_UID:$DAEMON_GID $dir/collections
-				chmod g-w,o-rwx $dir/collections
+				[ -e $dir ] || mkdir -p $dir
+				chown $DAEMON_UID:$DAEMON_GID $dir
+				chmod g-w,o-rwx $dir
 			fi
 		fi
 	done
@@ -70,7 +70,7 @@
 	start-stop-daemon --start --quiet --startas $DAEMON \
 		--exec $DAEMON --test > /dev/null \
 		|| return 1
-	start-stop-daemon --start --quiet --startas $DAEMON --background \
+	start-stop-daemon --start --quiet --startas $DAEMON --background --output $LOGDIR/$NAME.log \
 		--exec $DAEMON --umask 0027 --chuid $DAEMON_UID:$DAEMON_GID -- \
 		$RADICALE_OPTS \
 		|| return 2

Reply via email to