Control: forwarded -1 https://github.com/Reference-ScaLAPACK/scalapack/issues/31
On Wed, Mar 13, 2024 at 12:44:37PM +0100, Lucas Nussbaum wrote: > > /<<PKGBUILDDIR>>/BLACS/SRC/igsum2d_.c: In function ‘igsum2d_’: > > /<<PKGBUILDDIR>>/BLACS/SRC/igsum2d_.c:154:7: error: implicit declaration of > > function ‘BI_imvcopy’; did you mean ‘BI_zmvcopy’? > > [-Werror=implicit-function-declaration] BLACS/SRC is a smelly mess of one-function files calling each other without (in most cases at least) bothering to declare prototypes. I started with adding the following prototypes to Bdef.h (before the last #endif) because adding them to individual files is too much work: void BI_dmvcopy(Int m, Int n, double *A, Int lda, double *buff); void BI_dvmcopy(Int m, Int n, double *A, Int lda, double *buff); void BI_imvcopy(Int m, Int n, Int *A, Int lda, Int *buff); void BI_ivmcopy(Int m, Int n, Int *A, Int lda, Int *buff); void BI_smvcopy(Int m, Int n, float *A, Int lda, float *buff); void BI_svmcopy(Int m, Int n, float *A, Int lda, float *buff); void BI_TransDist(BLACSCONTEXT *ctxt, char scope, Int m, Int n, Int *rA, Int *cA, Int ldrc, BI_DistType *dist, Int rdest, Int cdest); But the next errors are things like "BLACS/SRC/blacs_init_.c:35:4: error: implicit declaration of function ‘blacs_gridmap_’" and blacs_init_.c calls either Cblacs_gridmap or blacs_gridmap_ but only declares a prototype for the former and at this point I think let's the authors of this code sort this mess. -- WBR, wRAR
signature.asc
Description: PGP signature