Source: libdrpm
Version: 0.5.1-1
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lu...@debian.org
Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.

This is most likely caused by a change in dpkg 1.22.6, that enabled
-Werror=implicit-function-declaration. For more information, see
https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration

Relevant part (hopefully):
> cd /<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/test && /usr/bin/cc   
> -fvisibility=hidden -g -O2 -Werror=implicit-function-declaration 
> -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong 
> -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection 
> -Wdate-time -D_FORTIFY_SOURCE=2 -O2 -g -DNDEBUG -std=c99 -pedantic -Wall 
> -Wextra -DHAVE_CONFIG_H -I/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu -MD -MT 
> test/CMakeFiles/drpm_api_tests.dir/__/src/drpm_apply.c.o -MF 
> CMakeFiles/drpm_api_tests.dir/__/src/drpm_apply.c.o.d -o 
> CMakeFiles/drpm_api_tests.dir/__/src/drpm_apply.c.o -c 
> /<<PKGBUILDDIR>>/src/drpm_apply.c
> /<<PKGBUILDDIR>>/src/drpm_utils.c:38:41: warning: argument 1 of type ‘const 
> unsigned char[2]’ with mismatched bound [-Warray-parameter=]
>    38 | uint16_t parse_be16(const unsigned char buffer[2])
>       |                     ~~~~~~~~~~~~~~~~~~~~^~~~~~~~~
> In file included from /<<PKGBUILDDIR>>/src/drpm_utils.c:23:
> /<<PKGBUILDDIR>>/src/drpm_private.h:237:21: note: previously declared as 
> ‘const unsigned char *’
>   237 | uint16_t parse_be16(const unsigned char *);
>       |                     ^~~~~~~~~~~~~~~~~~~~~
> /<<PKGBUILDDIR>>/src/drpm_utils.c:44:41: warning: argument 1 of type ‘const 
> unsigned char[4]’ with mismatched bound [-Warray-parameter=]
>    44 | uint32_t parse_be32(const unsigned char buffer[4])
>       |                     ~~~~~~~~~~~~~~~~~~~~^~~~~~~~~
> /<<PKGBUILDDIR>>/src/drpm_private.h:238:21: note: previously declared as 
> ‘const unsigned char *’
>   238 | uint32_t parse_be32(const unsigned char *);
>       |                     ^~~~~~~~~~~~~~~~~~~~~
> /<<PKGBUILDDIR>>/src/drpm_utils.c:53:41: warning: argument 1 of type ‘const 
> unsigned char[8]’ with mismatched bound [-Warray-parameter=]
>    53 | uint64_t parse_be64(const unsigned char buffer[8])
>       |                     ~~~~~~~~~~~~~~~~~~~~^~~~~~~~~
> /<<PKGBUILDDIR>>/src/drpm_private.h:239:21: note: previously declared as 
> ‘const unsigned char *’
>   239 | uint64_t parse_be64(const unsigned char *);
>       |                     ^~~~~~~~~~~~~~~~~~~~~
> /<<PKGBUILDDIR>>/src/drpm_utils.c:66:45: warning: argument 2 of type 
> ‘unsigned char[4]’ with mismatched bound [-Warray-parameter=]
>    66 | void create_be32(uint32_t in, unsigned char out[4])
>       |                               ~~~~~~~~~~~~~~^~~~~~
> /<<PKGBUILDDIR>>/src/drpm_private.h:233:28: note: previously declared as 
> ‘unsigned char *’
>   233 | void create_be32(uint32_t, unsigned char *);
>       |                            ^~~~~~~~~~~~~~~
> /<<PKGBUILDDIR>>/src/drpm_utils.c:75:45: warning: argument 2 of type 
> ‘unsigned char[8]’ with mismatched bound [-Warray-parameter=]
>    75 | void create_be64(uint64_t in, unsigned char out[8])
>       |                               ~~~~~~~~~~~~~~^~~~~~
> /<<PKGBUILDDIR>>/src/drpm_private.h:234:28: note: previously declared as 
> ‘unsigned char *’
>   234 | void create_be64(uint64_t, unsigned char *);
>       |                            ^~~~~~~~~~~~~~~
> /<<PKGBUILDDIR>>/src/drpm_write.c: In function ‘write_deltarpm’:
> /<<PKGBUILDDIR>>/src/drpm_write.c:94:20: error: implicit declaration of 
> function ‘strlen’ [-Werror=implicit-function-declaration]
>    94 |     src_nevr_len = strlen(delta->src_nevr) + 1;
>       |                    ^~~~~~
> /<<PKGBUILDDIR>>/src/drpm_write.c:30:1: note: include ‘<string.h>’ or provide 
> a declaration of ‘strlen’
>    29 | #include <rpm/rpmlib.h>
>   +++ |+#include <string.h>
>    30 | 
> /<<PKGBUILDDIR>>/src/drpm_write.c:94:20: warning: incompatible implicit 
> declaration of built-in function ‘strlen’ [-Wbuiltin-declaration-mismatch]
>    94 |     src_nevr_len = strlen(delta->src_nevr) + 1;
>       |                    ^~~~~~
> /<<PKGBUILDDIR>>/src/drpm_write.c:94:20: note: include ‘<string.h>’ or 
> provide a declaration of ‘strlen’
> /<<PKGBUILDDIR>>/src/drpm_write.c: In function ‘compstrm_wrapper_write’:
> /<<PKGBUILDDIR>>/src/drpm_write.c:364:9: error: implicit declaration of 
> function ‘memcpy’ [-Werror=implicit-function-declaration]
>   364 |         memcpy(csw->uncomp_data + csw->uncomp_len - csw->uncomp_left, 
> buffer, write_len);
>       |         ^~~~~~
> /<<PKGBUILDDIR>>/src/drpm_write.c:364:9: note: include ‘<string.h>’ or 
> provide a declaration of ‘memcpy’
> /<<PKGBUILDDIR>>/src/drpm_write.c:364:9: warning: incompatible implicit 
> declaration of built-in function ‘memcpy’ [-Wbuiltin-declaration-mismatch]
> /<<PKGBUILDDIR>>/src/drpm_write.c:364:9: note: include ‘<string.h>’ or 
> provide a declaration of ‘memcpy’
> /<<PKGBUILDDIR>>/src/drpm_write.c: In function ‘compstrm_wrapper_finish’:
> /<<PKGBUILDDIR>>/src/drpm_write.c:389:5: error: implicit declaration of 
> function ‘memmove’ [-Werror=implicit-function-declaration]
>   389 |     memmove(data_tmp + csw->uncomp_len, data_tmp, *data_len);
>       |     ^~~~~~~
> /<<PKGBUILDDIR>>/src/drpm_write.c:389:5: note: include ‘<string.h>’ or 
> provide a declaration of ‘memmove’
> /<<PKGBUILDDIR>>/src/drpm_write.c:389:5: warning: incompatible implicit 
> declaration of built-in function ‘memmove’ [-Wbuiltin-declaration-mismatch]
> /<<PKGBUILDDIR>>/src/drpm_write.c:389:5: note: include ‘<string.h>’ or 
> provide a declaration of ‘memmove’
> /<<PKGBUILDDIR>>/src/drpm_write.c:390:5: warning: incompatible implicit 
> declaration of built-in function ‘memcpy’ [-Wbuiltin-declaration-mismatch]
>   390 |     memcpy(data_tmp, csw->uncomp_data, csw->uncomp_len);
>       |     ^~~~~~
> /<<PKGBUILDDIR>>/src/drpm_write.c:390:5: note: include ‘<string.h>’ or 
> provide a declaration of ‘memcpy’
> [ 58%] Building C object 
> test/CMakeFiles/drpm_api_tests.dir/__/src/drpm_block.c.o
> cd /<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/test && /usr/bin/cc   
> -fvisibility=hidden -g -O2 -Werror=implicit-function-declaration 
> -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong 
> -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection 
> -Wdate-time -D_FORTIFY_SOURCE=2 -O2 -g -DNDEBUG -std=c99 -pedantic -Wall 
> -Wextra -DHAVE_CONFIG_H -I/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu -MD -MT 
> test/CMakeFiles/drpm_api_tests.dir/__/src/drpm_block.c.o -MF 
> CMakeFiles/drpm_api_tests.dir/__/src/drpm_block.c.o.d -o 
> CMakeFiles/drpm_api_tests.dir/__/src/drpm_block.c.o -c 
> /<<PKGBUILDDIR>>/src/drpm_block.c
> [ 61%] Building C object 
> test/CMakeFiles/drpm_api_tests.dir/__/src/drpm_compstrm.c.o
> cd /<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/test && /usr/bin/cc   
> -fvisibility=hidden -g -O2 -Werror=implicit-function-declaration 
> -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong 
> -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection 
> -Wdate-time -D_FORTIFY_SOURCE=2 -O2 -g -DNDEBUG -std=c99 -pedantic -Wall 
> -Wextra -DHAVE_CONFIG_H -I/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu -MD -MT 
> test/CMakeFiles/drpm_api_tests.dir/__/src/drpm_compstrm.c.o -MF 
> CMakeFiles/drpm_api_tests.dir/__/src/drpm_compstrm.c.o.d -o 
> CMakeFiles/drpm_api_tests.dir/__/src/drpm_compstrm.c.o -c 
> /<<PKGBUILDDIR>>/src/drpm_compstrm.c
> /<<PKGBUILDDIR>>/src/drpm_block.c:285:52: warning: argument 2 of type 
> ‘unsigned char[8192]’ with mismatched bound [-Warray-parameter=]
>   285 | int blocks_next(struct blocks *blks, unsigned char 
> buffer[BLOCK_SIZE], size_t *buffer_len,
>       |                                      ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~
> In file included from /<<PKGBUILDDIR>>/src/drpm_block.c:23:
> /<<PKGBUILDDIR>>/src/drpm_private.h:143:34: note: previously declared as 
> ‘unsigned char *’
>   143 | int blocks_next(struct blocks *, unsigned char *, size_t *, uint64_t, 
> size_t,
>       |                                  ^~~~~~~~~~~~~~~
> cc1: some warnings being treated as errors
> make[3]: *** [src/CMakeFiles/drpm.dir/build.make:261: 
> src/CMakeFiles/drpm.dir/drpm_write.c.o] Error 1


The full build log is available from:
http://qa-logs.debian.net/2024/03/13/libdrpm_0.5.1-1_unstable.log

All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lu...@debian.org
or:
https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20240313&fusertaguser=lu...@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.

Reply via email to