Bug#1024977: mmutf8fix does not fix omusrmsg

[Michael Biebl]

Control: tags -1 + upstream

On Mon, 28 Nov 2022 14:33:04 +1100 "Trent W. Buck" <trentb...@gmail.com> wrote:

Package: rsyslog
Version: 8.2102.0-2+deb11u1
Severity: minor

Using the attached rsyslog.conf, with this test log:

    /usr/bin/printf 'TEST BYTES 
\xc3\xb1\xc3\x28\xa0\xa1\xe2\x82\xa1\xe2\x28\xa1\xe2\x82\x28\xf0\x90\x8c\xbc\xf0\x28\x8c\xbc\xf0\x90\x28\xbc\xf0\x28\x8c\x28\xf8\xa1\xa1\xa1\xa1\xfc\xa1\xa1\xa1\xa1\xa1'
 | logger -p auth.0 -t invalid-utf8-test

...I find that mmutf8fix has fixed auth.log, but not the emergency
event printed to logged-in terminals.

I *guess* this is because omusrmsg uses "properties" instead of "the message"?

    Note that once it has been called, it actually modifies the message.
    The original messsage is then no longer available.
    However, this DOES NOT CHANGE ANY PROPERTIES set, used or extracted before 
the modification is done.

    
https://rsyslog.readthedocs.io/en/latest/configuration/modules/mmutf8fix.html


This issue doesn't really bother me, but
it would be nice if it was explicitly mentioned in the documentation, e.g.

    For example, omusrmsg will not be affected, because
    it uses properties (ignored by mmutf8fix) and ignores the message (fixed by 
mmutf8fix).

https://github.com/rsyslog/rsyslog/issues/
or

As the Debian package does not ship any patches in that regard, please consider filing this directly upstream at https://github.com/rsyslog/rsyslog-doc/issues/ if you think this is a documentation issue.

OpenPGP_signature.asc
Description: OpenPGP digital signature