On Thu, 22 Feb 2024 at 08:53, Helmut Grohne <hel...@subdivi.de> wrote: > On Thu, Feb 22, 2024 at 08:26:16AM -0800, Tianon Gravi wrote: > > It is precisely those older versions that the code still exists for -- > > I use debuerreotype for creating reproducible rootfs builds all the > > way back to slink. 😄 > > > > You can see in [1] that it only runs that diversion iff "upstart" > > exists in the repos we're pointed at. > > > > [1]: > > https://github.com/debuerreotype/debuerreotype/blob/60b625d1ce31bd81525bb67fc3a33f9686bc3433/scripts/debuerreotype-minimizing-config#L40 > > Right. Given that upstart no longer exists, it won't be /usr-moved and > hence that diversion should continue to work, right? I'm inclined to > agree that nothing needs to be done here. Does it make sense to add a > source code comment about this? If not, please just close this bug.
It's one better: that divert code won't even run. It will only run against older versions where upstart *did* exist (which were never usr-merged, and that divert is inside the old chroot), so yes, it will continue to work correctly even in a usr-merged world (unless we get some *new* package named "upstart", but I hope we don't run into that and I will adjust that conditional to be more defensive if we do). 😀 ♥, - Tianon 4096R / B42F 6819 007F 00F8 8E36 4FD4 036A 9C25 BF35 7DD4
