On Mon, Jan 29, 2024 at 04:58:47PM +0100, Steinar H. Gunderson wrote: > Package: libzstd-dev > Version: 1.5.5+dfsg2-2 > Severity: normal > > Hi, > > debian/rules contains > > dh_makeshlibs -plibzstd1 -V'libzstd1 (>= 1.5.5)' --add-udeb=libzstd1-udeb > > Would it be possible to change it to 1.5.4? I don't see anything between 1.5.4 > and 1.5.5 that would mean 1.5.5-built packages wouldn't work on 1.5.4, > and this would allow trixie-built .debs to be installable on bookworm. > (Of course, it would break if upstream truly introduces new APIs, but that's > fine.)
Hmmm, my understanding might be wrong, but when using dh_makeshlibs directly without a symbols file, isn't it going to be a problem if a program is built against libzstd 1.5.5 and it uses the new ZSTD_CCtx_setFParams() function? > Ideally, of course, one would ship a .symbols file instead of .shlibs, > but that requires more careful tracking. Now that is interesting. I actually prefer using symbols files for shared libraries when possible for obvious reasons, but I was still under the impression that the libzstd upstream build system was not ready for that - see e.g. https://salsa.debian.org/pkg-rpm-team/libzstd/-/commit/7f600c89ec9dffefd0017190313dbc9a050b8798 and, hence, https://github.com/facebook/zstd/pull/2501 ...and I just realized that !2501 was merged.... back in version 1.5.1! Huh. That's actually pretty cool, so now I can start using a symbols file for libzstd, too! OK, so since I still believe that lowering the version given to dh_makeshlibs would break programs that use the two new functions in 1.5.5, what do you think about the idea to start using symbols files instead? With some careful backporting (for my build purposes only), I believe I could craft a symbols file that would go back all the way to version 1.5.1. That's earlier than the 1.5.4 version in bookworm, so I think it might still suit your goal? Thanks for bringing this up - I really hadn't noticed that the "really export symbols with care" merge request had been merged! G'luck, Peter -- Peter Pentchev r...@ringlet.net r...@debian.org p...@storpool.com PGP key: http://people.FreeBSD.org/~roam/roam.key.asc Key fingerprint 2EE7 A7A5 17FC 124C F115 C354 651E EFB0 2527 DF13
signature.asc
Description: PGP signature
