Hi,

Thanks for the report.

> As per Ondřej's note below, with regards to MySQL support, from a glance
> through the source code (adminer/drivers/mysql.inc.php) it seems that
> adminer should depend on php-mysql (real metapackage) OR php-mysqli
> (virtual package provided by real phpX.Y-mysql package - i.e. currently
> php8.2-mysql).
>
> On 25/1/24 16:05, Ondřej Surý wrote:
> > The extension package provide names of the extensions actually provided by 
> > the said package. “mysql” extension has been removed from PHP a quite a 
> > while ago and is not provided by php8.2-mysql package. (Similar situation 
> > can be found in php8.2-xml package.)
> >
> > This needs to be fixed in the adminer, so it actually depends on an 
> > extension it actually uses.
> >
> > Ondrej
> > --
> > Ondřej Surý (He/Him)
> >
>
> Please find a patch attached to resolve this issue - #1061469. Hopefully
> I got it right?

I've been wrapping my head around this and still fail to understand
the actual problem.

php-mysql depends on php8.2-mysql which provides php-mysqli and
contains mysqli.so

For adminer, adding an alternate dependency to php-mysqli would
tighten (adminer actually requires mysqli.so or pdo_mysql.so loaded in
PHP for mysql interaction). But then why keep the dependency on
php-mysql?

The patch becomes:

diff --git a/debian/control b/debian/control
index 35a3f2a..43b2d7d 100644
--- a/debian/control
+++ b/debian/control
@@ -14,11 +14,11 @@ Package: adminer
 Architecture: all
 Depends:
  libapache2-mod-php | php-cgi | php-fpm | php,
- php-mysql | php-sqlite3 | php-pgsql,
+ php-mysqli | php-pdo-mysql | php-sqlite3 | php-pgsql,
  ${misc:Depends},
 Recommends:
  php-cli,
- php-mysql,
+ php-mysqli,
  php-pgsql,
  php-sqlite3,
  ${misc:Recommends},

Or is there something I missed?

Alex

Reply via email to