On Tue, Jan 09, 2024 at 12:06:40AM +0200, Niko Tyni wrote: > > It tries to retain compatibility with perlapi-5.36.0 on architectures where > > this is appropriate (64-bit architectures + i386); it covers Debian release > > architectures + riscv64, but does not attempt to be complete for all > > architectures dpkg knows about.
> Is there a reason you're bumping the abi for all the architectures rather > than just the affected ones? I'd expect this to be "opt in" so perlabi > would be defined just for armhf, hppa and so forth. > I'm thinking something like what we did for the s390x jmp_buf thing > ifeq (s390x-linux-gnu,$(shell dpkg-architecture -qDEB_HOST_GNU_TYPE)) > perlabi = 5.18.2d > else > perlabi = > endif > as per > https://salsa.debian.org/perl-team/interpreter/perl/-/commit/a66f196c13108b04909f9ec0e05986983cb2ed19 That's a very good point that I didn't think of, I'm +1 for doing it this way. > > This is entirely optional anyway, as perl > > 5.38 is just around the corner, at which point this patch should be dropped > > completely (assuming time_t lands before perl 5.38 does). > > TBH I was hoping 5.38 would land first :) And it has \o/ Do you want me to provide an updated patch, or will you integrate this on your side? > OOC, have you got the perl test suite passing with time64? I just did > a quick try on i386 with just DEB_BUILD_OPTIONS=abi=+time64 and I'm > seeing > Failed 7 tests out of 2623, 99.73% okay. > ../cpan/DB_File/t/db-btree.t > ../cpan/DB_File/t/db-hash.t > ../cpan/DB_File/t/db-recno.t > ../cpan/DB_File/t/db-threads.t > ../cpan/Memoize/t/errors.t > ../cpan/Memoize/t/tie.t > porting/libperl.t > but I guess that's because things like libdb5.3 need to be rebuilt first? Sorry, haven't tried anything like this yet. ABI skew with dependencies could certainly explain test suite failures! -- Steve Langasek Give me a lever long enough and a Free OS Debian Developer to set it on, and I can move the world. Ubuntu Developer https://www.debian.org/ slanga...@ubuntu.com vor...@debian.org
signature.asc
Description: PGP signature
