On 2023-11-13, Arnaud Ferraris wrote: > Le 18/05/2023 à 17:42, Vagrant Cascadian a écrit : >> >> Unfortunately, this will have to wait till after bookworm release, >> currently scheduled for June. > > Gentle ping with the hope that you (or Jonas) have some bandwidth to > take a look at this patch ;)
Sorry it has taken so long to get a look at these ... especially because the patches no longer apply. :( I noticed a few whitespace changes in the original patch that almost hide some of the changes; this patch is involved enough that it would be nice to reduce these to make it easier to review, for example: diff --git a/debian/u-boot-menu.install b/debian/u-boot-menu.install index 695129f..4816e32 100644 --- a/debian/u-boot-menu.install +++ b/debian/u-boot-menu.install @@ -1,4 +1,4 @@ -read-config usr/share/u-boot-menu -u-boot-update usr/sbin -zz-u-boot-menu etc/kernel/postinst.d -zz-u-boot-menu etc/kernel/postrm.d +read-config usr/share/u-boot-menu +u-boot-update usr/sbin +postinst/zz-u-boot-menu etc/kernel/postinst.d +postrm/zz-u-boot-menu etc/kernel/postrm.d My guess is this was to align with the longer lines, but I'd personally rather see just the two lines of diff rather than rewriting the whole file. live well, vagrant
signature.asc
Description: PGP signature
