Hi Lorenzo, On Wed, Jan 03, 2024 at 08:23:38PM +0100, Lorenzo Puliti wrote: > If I undestrand correctly (there was a PM from Helmut explaining this > to me, but it was before [1]) runit init needs a conflicts with > molly-guard when it moves halt, poweroff, etc.. links from /sbin > to /usr/sbin. Now, following patches already applied to systemd > and reading [2], I'm attempting a patchset for runit-init.
Many thanks for working on this! > [I know it's holiday time and I'm not in a rush for this] > Helmut, could you have a look (patches attached)? Sure! > * Is molly-guard enough or do I need to consider other packages? > I'm excluding progress-linux-container and bfh-container since > they depends on systemd-sysv The ones you name are all and I agree with your reasoning. > * the conflicts is in patch 003, restore the links is in 004 > * note that for consistency I'm also moving runit's shutdown > from /lib/runit/ to /usr/lib/runit. For that I have to bump > the Depends to the latest runit (patch 001), I hope that it > doesn't create issues to the apt resolver Sounds good. I read your patches and I found all the changes I was expecting there (including the link restoration). LGTM In your followup you asked about molly-guard missing Breaks now. This is correct. Earlier, the idea was to have molly-guard declare versioned Breaks for the packages it diverts. That way it could avoid supporting the aliased locations (beyond the upgrade). It turned out that this mutual Breaks+Conflicts causes apt to schedule a temporary removal, which in turn causes packages to be unpacked in a bad order and as a consequence causes file loss. The longer story is to be found on debian-devel@l.d.o. Long story short: We avoid this by not having mutual Breaks+Conflicts and thus molly-guard has to support working with the bookworm runit, which is more effort on the molly-guard side, but less file loss. Please go ahead with these changes. Will you be able to upload them to experimental for testing? Note that there is less urgency now, because molly-guard does not issue Breaks! This should be done by trixie, which still leaves plenty of time, so get it right rather than rushing. Thank you very much Helmut
