Hi tobi.
Thanks for replied.
 
Previously. I thinked that there was a conflict between the new version
and the old one.So we bump soname and broke the old package. Now 
i recognize that its not necessary.


I have fixed all the issues you raised, and remove the force build on ancient

C++ standard.


The lastest package address: https://mentors.debian.net/package/libkysdk-base/


xibowen.
 
------------------ Original ------------------
From: &nbsp;"Tobias Frost"<t...@debian.org&gt;;
Date: &nbsp;Tue, Dec 19, 2023 03:30 AM
To: &nbsp;"xibowen"<xibo...@openkylin.top&gt;; 
"1052597"<1052...@bugs.debian.org&gt;; 

Subject: &nbsp;Re: Bug#1052597: RFS: libkysdk-base/2.2.0.1-1 -- common files 
for kylin sdk base library

&nbsp;

Control: tags -1 moreinfo

Hi xibowen,
On Mon, Oct 30, 2023 at 11:23:33AM +0800, xibowen wrote:
&gt; Hi. thanks for reply.
&gt; 
&gt; &gt;
&gt; &gt; I'm curious if libkysdk-base-common is really needed? This will also
&gt; &gt; require a NEW processing btw.
&gt; &gt;
&gt; 
&gt; I have removed the libkysdk-base-common and uploaded to mentors.
&gt; 
&gt; Lastest upload: https://mentors.debian.net/package/libkysdk-base/
&gt; 
&gt;&nbsp; libkysdk-base (2.2.0.1-1) unstable; urgency=medium
&gt;&nbsp; .
&gt;&nbsp; &nbsp; * Update libs soname version.
&gt;&nbsp; &nbsp; * Fix compile error on armhf and ppc64el.
&gt;&nbsp; &nbsp; * d/control:
&gt;&nbsp;&nbsp;&nbsp; &nbsp; - Add Multi-Arch.

(this is a partial review, as I ran out of time.)

- Updating the SONAME of a library requires this procedure to be followed:
https://wiki.debian.org/Teams/ReleaseTeam/Transitions
&nbsp; Comparing the symbols file does not make it obvious why you are
&nbsp; bumping SONAME, but I did not check with abi-complicance-checker...
&nbsp; Can you fill me in why you bump the soname?

- the breaks/replaces version seems odd, as it is a binnmu version.
&nbsp; You likely want (<< 2.2.0.1-1~), though I am not sure why you think
&nbsp; you'll need the Break/Replace? Can you exand?

- you could use d/clean instead of overriding dh_clean

- for the install files, for multiarch, a cleaner way would be to write
&nbsp; /usr/lib/${DEB_HOST_MULTIARCH}/… instead of /usr/lib/*/…

-- 
Cheers,
tobi

Reply via email to