On Wed, 8 Nov 2023 23:07:54 +0000 Simon McVittie <s...@debian.org> wrote: > Source: rust-gdk-pixbuf-sys > Version: 0.18.0-2 > Severity: important > > While testing a proposed update for gobject-introspection I found that > rust-gdk-pixbuf-sys FTBFS when built in sbuild with the nocheck build > profile: >> > Command: dpkg-buildpackage --sanitize-env -Pnocheck -us -uc -B -rfakeroot
> ... > > debian/rules execute_before_dh_auto_build > > make[1]: Entering directory '/<<PKGBUILDDIR>>' > > cp /usr/share/gir-1.0/GLib-2.0.gir /<<PKGBUILDDIR>>> > cp: cannot stat '/usr/share/gir-1.0/GLib-2.0.gir': No such file or directory
>> Either libgirepository1.0-dev should not be <!nocheck>, or that cp command
> needs to be skipped when built with nocheck. > > (Other GObject-Introspection-adjacent Rust libraries might have the same > issue, I haven't attempted to rebuild all of them.) >
Hi Simon, thanks for this. This makes sense; I did in fact not set nocheck.The build must/should fail if libgirepository1.0-dev is not present. I opted to regenerate all gtk-rs code in debian.
This needs the .gir file(s) to be present as that's how the regeneration works (and emulates upstreams' workflow in debian).
Quoting the wiki on nocheck: "No test suite should be run, and build dependencies used only for that purpose should be ignored".
So I don't think we can set nocheck as it is a hard dependency rather than a test-dependency. The source code in the package gets created by the rules file
where depending on the package a specific set of the .gir files **must** be present. I introduced this to comply with ftpmasters so we can ship the newer ones.
best, -- Matthias Geiger <werdahias> Debian Maintainer "Freiheit ist immer Freiheit des anders Denkenden" -- Rosa Luxemburg
OpenPGP_0x18BD106B3B6C5475.asc
Description: OpenPGP public key
OpenPGP_signature.asc
Description: OpenPGP digital signature
