Package: libhackrf0
Version: 2023.01.1-2
Severity: important
Tags: patch
User: helm...@debian.org
Usertags: dep17p7
X-Debbugs-Cc: helm...@debian.org

Dear Maintainer,

libhackrf0 contains udev files which are installed to /lib; these files
need to be moved to /usr/lib as part of Debian's usr-merge effort.
Because your package is Multi-Arch: same, an unfortunate corner-case can
occur whereby shared files (such as the udev rules) may be erroneously
removed on upgrades (please see DEP17[1] P7: Shared multiarch file
loss).

You will find a patch attached to move the udev files, including the
mitigation for the file loss scenario.

Please consider applying this patch at your earliest convenience. This
bug will be upgraded to release critical soon, as it blocks the overall
usr-merge effort which is being undertaken for the trixie release.


Many thanks,
Chris


[1] https://wiki.debian.org/UsrMerge
diff -Nru hackrf-2023.01.1/debian/changelog hackrf-2023.01.1/debian/changelog
--- hackrf-2023.01.1/debian/changelog   2023-10-15 02:26:21.000000000 +0200
+++ hackrf-2023.01.1/debian/changelog   2023-11-26 20:37:03.000000000 +0100
@@ -1,3 +1,11 @@
+hackrf (2023.01.1-2.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Move udev files from /lib to /usr/lib, including protective diversion
+    against Multi-Arch: same file loss scenario (DEP17 P7 M10). (Closes: #-1)
+
+ -- Chris Hofstaedtler <z...@debian.org>  Sun, 26 Nov 2023 20:37:03 +0100
+
 hackrf (2023.01.1-2) unstable; urgency=medium
 
   * update to v2023.01.1-15-g1fd67f66 (Closes: #1036862)
diff -Nru hackrf-2023.01.1/debian/libhackrf0.lintian-overrides 
hackrf-2023.01.1/debian/libhackrf0.lintian-overrides
--- hackrf-2023.01.1/debian/libhackrf0.lintian-overrides        1970-01-01 
01:00:00.000000000 +0100
+++ hackrf-2023.01.1/debian/libhackrf0.lintian-overrides        2023-11-26 
20:36:59.000000000 +0100
@@ -0,0 +1,4 @@
+# begin-remove-after: released:forky
+# protective diversion for upgrades of files moved from / to /usr
+libhackrf0: diversion-for-unknown-file lib/udev/rules.d/60-libhackrf0.rules 
[preinst:*]
+# end-remove-after
diff -Nru hackrf-2023.01.1/debian/libhackrf0.postinst 
hackrf-2023.01.1/debian/libhackrf0.postinst
--- hackrf-2023.01.1/debian/libhackrf0.postinst 1970-01-01 01:00:00.000000000 
+0100
+++ hackrf-2023.01.1/debian/libhackrf0.postinst 2023-11-26 20:36:59.000000000 
+0100
@@ -0,0 +1,16 @@
+#! /bin/sh
+
+set -e
+
+# begin-remove-after: released:forky
+# protective diversion of files moved from / to /usr, to avoid file loss.
+# Only for upgrades.
+if [ "$1" = "configure" ]; then
+    # At this point, the package will have installed the same file in */usr*.
+    dpkg-divert --package usr-is-merged --no-rename \
+        --divert /lib/udev/rules.d/60-libhackrf0.rules.usr-is-merged \
+        --remove /lib/udev/rules.d/60-libhackrf0.rules
+fi
+# end-remove-after
+
+#DEBHELPER#
diff -Nru hackrf-2023.01.1/debian/libhackrf0.postrm 
hackrf-2023.01.1/debian/libhackrf0.postrm
--- hackrf-2023.01.1/debian/libhackrf0.postrm   1970-01-01 01:00:00.000000000 
+0100
+++ hackrf-2023.01.1/debian/libhackrf0.postrm   2023-11-26 20:36:59.000000000 
+0100
@@ -0,0 +1,16 @@
+#!/bin/sh
+set -e
+
+# begin-remove-after: released:forky
+# protective diversion of files moved from / to /usr, to avoid file loss.
+# Only for upgrades.
+if [ "$1" = "remove" ] && [ "$DPKG_MAINTSCRIPT_PACKAGE_REFCOUNT" = "1" ]; then
+    # Cleanup in case package is removed before upgrade is finished (postinst 
ran).
+    dpkg-divert --package usr-is-merged --no-rename \
+        --divert /lib/udev/rules.d/60-libhackrf0.rules.usr-is-merged \
+        --remove /lib/udev/rules.d/60-libhackrf0.rules
+fi
+# end-remove-after
+
+#DEBHELPER#
+
diff -Nru hackrf-2023.01.1/debian/libhackrf0.preinst 
hackrf-2023.01.1/debian/libhackrf0.preinst
--- hackrf-2023.01.1/debian/libhackrf0.preinst  1970-01-01 01:00:00.000000000 
+0100
+++ hackrf-2023.01.1/debian/libhackrf0.preinst  2023-11-26 20:36:59.000000000 
+0100
@@ -0,0 +1,15 @@
+#!/bin/sh
+set -e
+
+# begin-remove-after: released:forky
+# protective diversion of files moved from / to /usr, to avoid file loss.
+# Only for upgrades.
+if [ "$1" = "upgrade" ]; then
+    dpkg-divert --package usr-is-merged --no-rename \
+        --divert /lib/udev/rules.d/60-libhackrf0.rules.usr-is-merged \
+        --add /lib/udev/rules.d/60-libhackrf0.rules
+fi
+# end-remove-after
+
+#DEBHELPER#
+
diff -Nru hackrf-2023.01.1/debian/rules hackrf-2023.01.1/debian/rules
--- hackrf-2023.01.1/debian/rules       2023-10-15 02:26:21.000000000 +0200
+++ hackrf-2023.01.1/debian/rules       2023-11-26 20:37:03.000000000 +0100
@@ -43,3 +45,9 @@
 
 override_dh_installdocs-indep:
        dh_installdocs --indep
+
+override_dh_installudev:
+       dh_installudev
+       # This should be harmless for indep builds or after dh_installudev 
changes the install path.
+       set -e; if test -d debian/libhackrf0/lib/udev/rules.d; then mv 
debian/libhackrf0/lib/udev debian/libhackrf0/usr/lib; fi
+       set -e; if test -d debian/libhackrf0/lib; then rmdir 
debian/libhackrf0/lib; fi

Reply via email to